search

GitoxideLabs / gitoxide

An idiomatic, lean, fast & safe pure Rust implementation of Git
Apache License 2.0
8.91k stars 303 forks source link

Update gitoxide repository URLs #1624

Closed EliahKagan closed 18 hours ago

EliahKagan commented 18 hours ago

This changes Byron/gitoxide URLs to GitoxideLabs/gitoxide in documentation and a few other places, now that the repository has been moved into an organization as detailed in #1406. The old URLs still work, redirecting to the new ones, so that change is not needed to fix broken links, but I think it is still a good idea. This makes the change in Markdown docs except those such as changelogs where it should not be done, in documentation comments, in manifest files, and in the documentary top-comment of the pre-push sample hook. See 64ff0a7 for details.

This also makes a few other changes to URLs that do fix broken links, which had been broken before and the above change led me to discover the breakage. For example, some links had previously had their paths updated to account for a rename without their OIDs being updated. See 65f69f7 for details. There are some more broken links I found during this process where the solution is less readily apparent; for those, I plan to open a separate PR and/or an issue requesting what should be done. It seemed to me that that those further hoped-for changes are non-blocking for this PR, since they pertain to links that were already broken and are made no worse here.

I think that when Byron/gitoxide appears in test data, it should usually be left unchanged, or at least not changed unless something nearby is already being changed. But in some places I think it makes sense to change it. See 507579e for details, including on why I did not change it in more places. However, I did update the URLs in the Makefile, as detailed in 1ea08bf.

Byron commented 18 hours ago

Thanks again for this very mindful update, something I conveniently skipped over entirely. In my mind I already moved on and probably would have relied on the redirect way too long 😅.

Also I am looking forward to the follow-up that deals with the previously broken links - I'd just trust your judgement with these as well.

EliahKagan commented 5 hours ago

Also I am looking forward to the follow-up

I've opened #1627 and #1628 to discuss and propose further improvements.

Please note that #1628 does not fix issue #1627 because it does not have anything for #1627's first two tasks.