search

GiulioRomualdi / scs-eigen

Simple Eigen-C++ wrapper for scs library
https://giulioromualdi.github.io/scs-eigen
MIT License
6 stars 1 forks source link

Building issues #4

Open biagio-trimarchi opened 9 months ago

biagio-trimarchi commented 9 months ago

I have found a series of issues in the building of the package.

First of all, there is missing include statements in the file Settings.h, in particular the file misses the #include<string_view> to use the string_view data type.

Moreover, the compiler raise the following error after fixing the missing include statement:


$ make
Consolidate compiler generated dependencies of target ScsEigen
[  7%] Building CXX object src/ScsEigen/CMakeFiles/ScsEigen.dir/src/Settings.cpp.o
/home/docker-dev/ws/scs_eigen_test/scs-eigen/src/ScsEigen/src/Settings.cpp: In member function ‘bool ScsEigen::Settings::eps(double)’:
/home/docker-dev/ws/scs_eigen_test/scs-eigen/src/ScsEigen/src/Settings.cpp:87:23: error: ‘struct ScsSettings’ has no member named ‘eps’
   87 |     m_pimpl->settings.eps = eps;
      |                       ^~~
/home/docker-dev/ws/scs_eigen_test/scs-eigen/src/ScsEigen/src/Settings.cpp: In member function ‘double ScsEigen::Settings::eps() const’:
/home/docker-dev/ws/scs_eigen_test/scs-eigen/src/ScsEigen/src/Settings.cpp:93:30: error: ‘struct ScsSettings’ has no member named ‘eps’
   93 |     return m_pimpl->settings.eps;
      |                              ^~~
make[2]: *** [src/ScsEigen/CMakeFiles/ScsEigen.dir/build.make:90: src/ScsEigen/CMakeFiles/ScsEigen.dir/src/Settings.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:158: src/ScsEigen/CMakeFiles/ScsEigen.dir/all] Error 2
make: *** [Makefile:136: all] Error 2```
S-Dafarra commented 9 months ago

cc @GiulioRomualdi

GiulioRomualdi commented 9 months ago

Hi @biagio-trimarchi, Thank you for reporting 😊 Let me check it better!