Closed dummyindex closed 2 years ago
Hi cdlib team,
Thanks for fixing the import issue mentioned in #201 . There is probably one more little code issue to be fixed.
Describe the bug
try: import infomap as imp except ModuleNotFoundError: missing_packages.add("infomap") imp = None
This does not catch ImportError, which is the case in my environment. After capturing Exception (all exception) in crisp_partition.py, bipartite_clustering.py (two files), I can import cdlib.algorithms without other issues.
ImportError
crisp_partition.py, bipartite_clustering.py
To Reproduce Steps to reproduce the behavior:
Screenshots
Thanks for the fix and code cleaning, @GiulioRossetti the pull request seems OK to me...
Hi cdlib team,
Thanks for fixing the import issue mentioned in #201 . There is probably one more little code issue to be fixed.
Describe the bug
This does not catch
ImportError
, which is the case in my environment. After capturing Exception (all exception) incrisp_partition.py, bipartite_clustering.py
(two files), I can import cdlib.algorithms without other issues.To Reproduce Steps to reproduce the behavior:
Screenshots