GiusTex / ComfyUI-DiffusersImageOutpaint

Diffusers Image Outpaint for ComfyUI
Apache License 2.0
56 stars 4 forks source link

The result is not very good .... #7

Closed coollofty closed 1 month ago

coollofty commented 1 month ago

1

2

Why are the results so different for the same image? I have tried many times and this is already a good result, others are bader. However, https://huggingface.co/spaces/fffiloni/diffusers-image-outpaint It only ran once here, and the result was great. The picture is the same one.

Other bad result sample: 3

GiusTex commented 1 month ago
coollofty commented 1 month ago

maotouyintg

GiusTex commented 1 month ago

The rounded angles don't work well, if you cut a bit the image to remove them it works well again.

Owl_1 90° angles.

ComfyUI_temp_sfbic_00003_

ComfyUI_temp_sfbic_00004_

coollofty commented 1 month ago

Well, I see. But why the effect on https://huggingface.co/spaces/fffiloni/diffusers-image-outpaint this website is very good, and the pixels at the edges have not affected it?

GiusTex commented 1 month ago

I don't know, maybe he updated the code to check if there are rounded corners, and if yes it cut the image automatically (?). I think that between all the updates (# Calculate new dimensions based on percentage, # Ensure minimum size of 64 pixels, # Calculate the overlap in pixels based on the percentage, # Ensure minimum overlap of 1 pixel, # Adjust margins to eliminate gaps, etc), the corners are probably fixed automatically, in a way or another

GiusTex commented 1 month ago

You think it would be useful an auto check for rounded corners, and if found, you are warned (or maybe the image is even auto-cropped) ?

coollofty commented 1 month ago

Yes, it can be like this, it's just strange. I thought your code was the same as the code with huggingface repo, so the effect should be exactly the same....I will test more other pictures, thanks

GiusTex commented 1 month ago

I thought your code was the same as the code with huggingface repo

It was, around 2 weeks ago, but filonii sometimes updates it, he added for example "Mask overlap (%)", "mask Overlap Top/Overlap Right/Overlap Left/Overlap Bottom", "Resize input image", and I didn't add them...