change logic of attestation issuance, to handle fees

divine-comedian commented 2 months ago

We added a resolver contract to enforce an exact amount of ETH to be sent with each attestation using our schema. This will affect users vouching flagging and editing their attestations (deleting/revoking remains unchanged, no fee).

AC

[ ] can successfully vouch to a project
[ ] can sucessfully flag a project
[ ] can successfully edit attestation made to project
[ ] can successfully revoke/delete attestation
[ ] fee of 0.0001 ETH is taken on vouch/flag/edit transactions (in addition to regular gas fee)
[ ] no fee is taken on revoke/delete attestation
[ ] new attestations for vouch/flag/edit shows on relevant project and user attestation history tables

divine-comedian commented 6 days ago

We've changed the approach of this feature now instead we deploy a resolver contract that will collect a specified fee for each attestation made using our schema.

if a user makes multiple attestations the fee also multiplies.

Here is a deployment on Sepolia we can start using right away:

https://sepolia.easscan.org/schema/view/0x87607c7f565dfc1473309a45e7f7d26f0915615258fffd6745fc6238822c108b

for each attestation it is expecting the user to send 0.0001 ETH

You can see some sample data in the tests I ran in foundry here: https://github.com/Giveth/DeVouch-contracts/blob/master/test/testDeployedResolver.t%20copy.sol#L40-L53

To-do

[x] - Add schema to back-end config https://github.com/Giveth/DeVouch-BE/issues/144
[ ] - change attestation flow for vouch/flag/edit to point to new schema
[ ] - add fee amount to attestation data
[ ] - add logic for sending correct amount of eth with transaction

divine-comedian commented 17 hours ago

for merging to production"

[ ] - deploy resolver to op mainnet
[ ] - create new schema
[ ] - add schema to backend config and FE environment variables
[ ] - test with foundry script to see if it shows up
[ ] add note in documentation about fees

LatifatAbdullahi commented 13 hours ago

@mateodaza @MohammadPCh

Test Update

Can successfully vouch to a project - Pass
- Can successfully flag a project - "Pass"
- Can successfully edit attestation made to project - "Pending"
- Vouch details reflects on Project card - Fail
- Vouch details reflects on Project details page - Fail
- Vouch details reflects on "My Attestation" page - Fail
- Flag details reflects on Project card - Fail
- Flag details reflects on Project details page - Fail
- Flag details reflects on "My Attestation" page - Fail
- Can successfully revoke/delete attestation - Pending
- Fee of 0.0001 ETH is taken on vouch/flag/edit transactions (in addition to regular gas fee) - "Pending"
No fee is taken on revoke/delete attestation - "Pending"
New attestations for vouch/flag/edit shows on relevant project and user attestation history tables - "Fail"

After successfully vouching and flagging a project, there is no record of the details on Project card, Project details page as well as my Attestation page