search

Giveth / GIVeconomy

The Giveth Economy is the collective of projects, donors, builders, and community members builders that build the future of giving
GNU General Public License v3.0
6 stars 0 forks source link

What do show in Gardens UI for "claim rewards" in GIVgarden #108

Closed laurenluz closed 2 years ago

laurenluz commented 2 years ago

Right now, the "claimable amount" showing in the GIVgarden is the claimable rewards + vested rewards (adding to the GIVstream)

And when you "claim" you get EVERYTHING allocated to you from the token distro... including the GIVbacks amount & what's liquid from the GIVstream.

So nothing about the numbers make sense... We need to decide which amount to show on the gardens UI, without giving the gardens team extra work.

Griff has 3 suggestions... To show:

  1. The way it is now: Stream + Claimable for the Garden staking
  2. The amount they will increase their balance with: Amount Claimable: the tokens from all streams that are being released on xDai
  3. "Yes" We just avoid the issue and let it be a surprise how much they are earning skip the number all together.

"All options are sort of weak... but Gardens should not have to make something custom for us... It will really suck for them"

I think it might be best if we just have a link to send them to the GIVfarm

laurenluz commented 2 years ago

Should check in with gardens team to see if it's possible to just have the claim button on their UI send the user to our GIVfarm page.

The number shown on the gardens UI is the number of claimable GIVtokens earned from the GIVgarden.

If we can't send them to our page, we should just show them the total amout of GIVtokens they're getting (liquid, not including stream)

laurenluz commented 2 years ago

It's possible! Fabri set it up for us so that when the user has rewards to claim, they click "claim" in the garden and get sent to our specified link.

For the test garden the user gets sent to this test GIVeconomy link

In the future, we can change it from the dao-list repo here https://github.com/1Hive/dao-list/blob/8b1becfc4505da9b7a458c1257b19ab4c62c1f03/xdai.json#L177

... just by creating a PR or asking the Gardens team