search

Giveth / analytics-dashboard

Analytics dashboard for Giveth data
https://stats.giveth.io/
GNU General Public License v3.0
23 stars 5 forks source link

create drop down menu to filter information by a specific network #9

Closed divine-comedian closed 2 months ago

divine-comedian commented 4 months ago

We should replace the current toggle for "Optimism Only" with a drop down menu allowing us to filter by any network that Giveth supports, including:

projects count

Donations Count

Total Donations ($)

RamRamez commented 3 months ago

only one network can be chosen at a time, so it's not needed to filter by two or more networks like mainnet and Op, @divine-comedian is that right?

divine-comedian commented 3 months ago

only one network can be chosen at a time, so it's not needed to filter by two or more networks like mainnet and Op, @divine-comedian is that right?

yes correct - either filter by one specific network or with no filter, which looks across all netwroks. we won't need to worry about filtering across two or more networks.

RamRamez commented 3 months ago

@maryjaf please test and verify

https://analytics-dashboard-git-9-add-dropdown-menu-givethio.vercel.app/

maryjaf commented 3 months ago

I couldn't move it to Done I have no access on analytics-dashboard

RamRamez commented 3 months ago

@MoeNick Could you please grant @maryjaf required permissions?

divine-comedian commented 3 months ago

moved it to done! Where could I test it?

ae2079 commented 3 months ago

moved it to done! Where could I test it?

You can test it by this link: https://analytics-dashboard-git-9-add-dropdown-menu-givethio.vercel.app/ this is a preview of the analytics dashboard's new changes with the staging data

divine-comedian commented 3 months ago

moved it to done! Where could I test it?

You can test it by this link: https://analytics-dashboard-git-9-add-dropdown-menu-givethio.vercel.app/ this is a preview of the analytics dashboard's new changes with the staging data

Nice! two things

  1. Make sure Polygon zkEVM is included in the drop down list (Polygon and Polygon zkEVM are two separate chains FYI)
  2. Is it possible to create a preview link with production data?
ae2079 commented 3 months ago

moved it to done! Where could I test it?

You can test it by this link: https://analytics-dashboard-git-9-add-dropdown-menu-givethio.vercel.app/ this is a preview of the analytics dashboard's new changes with the staging data

Nice! two things

1. Make sure Polygon zkEVM is included in the drop down list (Polygon and Polygon zkEVM are two separate chains FYI)

2. Is it possible to create a preview link with production data?

I added the Polygon zkEVM just now, and for the second one, I think @RamRamez should add it because I don't have access to vercel dashboard, and also, the changes on the impact-graph repo should be deployed on production before this

divine-comedian commented 3 months ago

Thanks! I don't think the second point will block us to test.

To test

eth goerli (this way not work, chain is deprecated)

gnosis chain

optimism-sepolia

arbitrum-seplia

eth classic-mordor

celo-alfajores

base sepolia

polygon mainnet

polygon zkevm cardona

Solana

ae2079 commented 3 months ago

@divine-comedian I wanted to put the issue in the QA/UAT but I see you had put it to done, If we need a QA test, please update it

divine-comedian commented 3 months ago

My Bad, I just asked @maryjaf to take another look and confirm the QA

maryjaf commented 3 months ago

This issue could be assigned to @LatifatAbdullahi to get onboard more on donation flow and different chains on stg @divine-comedian

divine-comedian commented 3 months ago

Sure! @maryjaf can you support

@LatifatAbdullahi to test this issue:

On all staging networks you'll need to do a few interactions check that analytics dashboard is correctly counting new interactions, make sure that as you do these interactions on the website that when you check the information on the analytics dashboard that you are filtering for the correct network.

e.g. - make donation on polygon zkEVM testnet -> check on analytics dashboard, filtered by donations on polygon zkEVM only using the new dropdown menu feature.

Here's a brief list of the actions you may need to take on every test network we support to properly test this new feature:

  1. add recipient addresses for new networks to a newly created project, check number goes up accordingly on "project count"
  2. make donations with a fresh user account, check donors and donations count goes up
  3. make donations with an existing user account, check donations count goes up
  4. using a token where the price is tracked, usually the native token, make donations with new or existing user, check usd value of donations increases accordingly

bear in mind it could take up to 5 minutes for new interactions to be registered by the analytics dashboard.

LatifatAbdullahi commented 3 months ago

Noted

On Mon, 1 Jul 2024, 00:56 Mitch, @.***> wrote:

Assigned #9 https://github.com/Giveth/analytics-dashboard/issues/9 to @LatifatAbdullahi https://github.com/LatifatAbdullahi.

— Reply to this email directly, view it on GitHub https://github.com/Giveth/analytics-dashboard/issues/9#event-13343383747, or unsubscribe https://github.com/notifications/unsubscribe-auth/A2YPQ6STWTG45GJSPXFWDADZKCLMFAVCNFSM6AAAAABIPU2AKOVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJTGM2DGMZYGM3TINY . You are receiving this because you were assigned.Message ID: @.***>

LatifatAbdullahi commented 3 months ago

@divine-comedian Test Status - In Progress

The Toggle for "Optimism Only" has now been replaced with a drop down menu allowing Users to filter by any network that

Pj This image is same for there sections such as Donors count, Donations Count, Total Donations

Gnosis chain Projects count : Pass Donors count: Pass Donations count : Pass Total USD Value Donations count: Progress (The token donated(DRGIV) had USD value: 0, therefore would need to verify with another token )

Filtering Projects count using the "Gnosis Chain" returned expected result for the 3 sections.

LatifatAbdullahi commented 3 months ago

@ae2079 @kkatusic

Currently experiencing a blocker with newly created Projects. After successfully creating a Project, In order to make donations to the Projects, it has to be verified and listed. The issue is, After Verifying and updating the status to "Listed" at the Giveth Admin , the Project status on the Project cards are updated, but it is not saved at the Giveth Admin section. Furthermore, when Users attempt to search for the Projects, even though the Project shows "Verified" and "Listed", the search results returns "There are no projects matching your search" and sometimes " 500;Internal Server Error".

Note: I received Email Notifications that My Projects were Live and Listed, but when searched, it returns no results.

I was able to test certain functions with Projects I created last week but there is only little I can verify with old Projects.

I created multiple projects attempting to make donations using different Networks, Projects are not coming up when searched even though they are verified and Listed, When Users attempt to Filter Project count by Network "Celo" it doesnt return expected result. Only that of "Gnosis" works as expected.

Also, verified Projects now returns the "Verify Project" Tag gh

LatifatAbdullahi commented 3 months ago

I have created bugs for the issues found (https://github.com/Giveth/giveth-dapps-v2/issues/4365) (https://github.com/Giveth/giveth-dapps-v2/issues/4363) (https://github.com/Giveth/giveth-dapps-v2/issues/4364)

I will continue testing the Analytics and update with my feedback

LatifatAbdullahi commented 3 months ago

@divine-comedian Thanks to @maryjaf she shared some tokens in OP-Sepolia and I had 2 XDAI shared by MoeNick lastweek. So I was able to complete Test for these two networks successfully and they work as expected, including filtering each section by the networks (OP Sepolia & Gnosis Chain). I would verify other Networks as soon as I get the test token for them

Gnosis chain

Optimism-sepolia

LatifatAbdullahi commented 3 months ago

@divine-comedian

**Base sepolia -projects count: Fail -donors count : Fail -donations count: Fail -total usd value donations count: Fail

Polygon mainnet

Polygon zkevm cardona

LatifatAbdullahi commented 3 months ago

@divine-comedian SOLANA DEVNET After a successful Donation to a new Project using Solana Network sol

-projects count : Fail -donors count: Fail -donations count: Fail -total usd value donations count: Fail

Solana -projects count : Fail pcc

-donors count: Fail solana Project donor

-donations count: Fail

solanaDDonations count

-total usd value donations count: Fail

SolanaTotalDonations Count

LatifatAbdullahi commented 3 months ago

@divine-comedian

ARBITRUM SEPOLIA After a successful donation to a new Project ar

-projects count : Fail -donors count: Fail -donations count: Fail -total usd value donations count: Fail

projects count : Fail arb

-donors count: Fail dc

-donations count: Fail rt

-total usd value donations count: Fail

td

ae2079 commented 3 months ago

@LatifatAbdullahi I think the last two comments were not a bug, because you used test-net and the network ID of test-net is different from the main-net

LatifatAbdullahi commented 3 months ago

@ae2079 Alright thanks for the info.

@divine-comedian For Solana, it means I have to test with "Solana" and not "Solana Devnet". If correct, I would need tokens for Solana, the amount I currently have cant be donated, it returns "Insufficient fund"

For "Arbitrum Sepolia" I am quite confused, which Network should I use instead?

LatifatAbdullahi commented 3 months ago

@divine-comedian

Test update on "ETHEREUM CLASSIC MORDOR"

I succesfully donated to a new Project, there was a confirmation modal, then another modal with "Transaction failed" popped-up The tokens have been deducted from the wallet, but no donations were registered, so I cant tell if the status of the Analytics dashboard just yet.

image

The deductions from the wallet

ethe

Project donated to: Tusteeproject

tr

No donations recorded

trr

LatifatAbdullahi commented 3 months ago

@divine-comedian @ae2079 SOLANA

After successfully donating to a project, there is no record of the donation, also no deduction from the Solana Wallet. Note: I have made two successful donations with no record of it, including on the Giveth Analytics board

image

The donations were made to this project: GreatProjectsLat

divine-comedian commented 3 months ago

@divine-comedian @ae2079 SOLANA

After successfully donating to a project, there is no record of the donation, also no deduction from the Solana Wallet. Note: I have made two successful donations with no record of it, including on the Giveth Analytics board

image

The donations were made to this project: GreatProjectsLat

This won't work - because donations made on unsupported networks won't be registered correctly by the dapp...

@ae2079 we need to fix the staging analytics dashboard so it correctly looks at all test networks and not arbitrarily looking at production networks - otherwise testing will be challenging since the dapp is not setup for these things and unexpected things will happen.

LatifatAbdullahi commented 3 months ago

@divine-comedian

CELO ALFAJORES Donation to the project was successful, the record is registered in the Project but no reflection in the Analytics board as well.

clo

ae2079 commented 2 months ago

I changed the networkIds for the staging as follows: arbitrum -> arbitrum sepolia optimism -> optimism sepolia base -> base sepolia zkEVM -> zkEVM cardona celo -> celo alfajores solana -> solana testnet ETC -> mordor ETC testnet note that this changes are only for the development environment and for the production, we still using mainnets @divine-comedian @LatifatAbdullahi you may be able to test it via this link: https://analytics-dashboard-eipk04f87-givethio.vercel.app/

divine-comedian commented 2 months ago

OK, @LatifatAbdullahi can you retest then arb sepolia and solana devnet - it will be helpful for the developer if you could summarize what isn't working from all test cases on all networks in a single clear comment

LatifatAbdullahi commented 2 months ago

Okay, got it!

LatifatAbdullahi commented 2 months ago

@divine-comedian @ae2079

This what I experience when Trying to donate to a project; I tried multiple times thinking it was my network but still same result https://drive.google.com/file/d/1wnJgSSmzR8wDktZOedln84DAISeGUZbx/view?usp=sharing

sy

When I was finally able to click on the donation button, the donation kept failing continously; Here is another video for this behaviour https://drive.google.com/file/d/1N_kUMnU1kn-W5BURAdCxy7Gk3j9L7AMG/view?usp=sharing

divine-comedian commented 2 months ago

I can confirm I also get the second error, this is very bad because now nobody can make donations on staging!

https://github.com/Giveth/analytics-dashboard/assets/67759413/f977afad-e861-49b5-bfa7-22721e4c843e

ae2079 commented 2 months ago

I can confirm I also get the second error, this is very bad because now nobody can make donations on staging! Screencast.2024-07-09.13.45.56.mp4

I will fix it as soon as possible, I'm on it

kkatusic commented 2 months ago

I can confirm I also get the second error, this is very bad because now nobody can make donations on staging! Screencast.2024-07-09.13.45.56.mp4

I will fix it as soon as possible, I'm on it

I was also checking, this is happen when FE call action DonationsByProjectId, it is problem on BE, if you @ae2079 find solution ping me I will check it and approve it.

ae2079 commented 2 months ago

I can confirm I also get the second error, this is very bad because now nobody can make donations on staging! Screencast.2024-07-09.13.45.56.mp4

I will fix it as soon as possible, I'm on it

I was also checking, this is happen when FE call action DonationsByProjectId, it is problem on BE, if you @ae2079 find solution ping me I will check it and approve it.

It looks like the migration do not change the database schema on staging data base, and I add the columns manually and now it works Screenshot 2024-07-10 010339 I check the pipeline and in this, it ran migration successfully but I don't know why it didn't affect staging database

ae2079 commented 2 months ago

@divine-comedian @LatifatAbdullahi now, you may be able to continue testing

kkatusic commented 2 months ago

@divine-comedian @LatifatAbdullahi now, you may be able to continue testing

Excellent @ae2079 , thx for fast fixing ;)

LatifatAbdullahi commented 2 months ago

@divine-comedian @ae2079 Test completed

Donation using both Arbitrum Sepolia and Solana Devnet were successful

Arbitrum Sepolia

Project count: Pass Donors count: Pass Donation count: Pass Total Donations: Pass

Solana Devnet

Project count: Fail Donors count: Fail Donation count: Fail Total Donations: Fail

LatifatAbdullahi commented 2 months ago

Also, after successfully donating with Solana Devnet, there is no record of the donation in that particular project

ae2079 commented 2 months ago

Also, after successfully donating with Solana Devnet, there is no record of the donation in that particular project

@divine-comedian I think the Solana test network is not available in the staging, and we should test it with the main net. Am I right? If we need to test it with the main net, please let me know to change the network ID of it.

ae2079 commented 2 months ago

Also, after successfully donating with Solana Devnet, there is no record of the donation in that particular project

@divine-comedian I think the Solana test network is not available in the staging, and we should test it with the main net. Am I right? If we need to test it with the main net, please let me know to change the network ID of it.

Looks like there is a problem with Solana dev net on staging from before (https://github.com/Giveth/giveth-dapps-v2/issues/4371), I will check it and when it is fixed, I will notice you.

divine-comedian commented 2 months ago

OK so from Latifat's test results we can see the following networks are failing the tests

@ae2079 - You'll need to investigate why these networks are not being captured by the analytics dashboard on staging. For Solana devent we'll need to find out why the network integration appears broken, as you mentioned in your previous comment.

ae2079 commented 2 months ago

OK so from Latifat's test results we can see the following networks are failing the tests

* Base sepolia

* Polygon zkevm cardona

* Celo Alfjores

* Ethereum Classic

* Solana Devnet

@ae2079 - You'll need to investigate why these networks are not being captured by the analytics dashboard on staging. For Solana devent we'll need to find out why the network integration appears broken, as you mentioned in your previous comment.

@LatifatAbdullahi Did you test these networks after the last change? I think after the last change the problem should be resolved. (except Solana, who had a problem in donation on the staging)

LatifatAbdullahi commented 2 months ago

OK, @LatifatAbdullahi can you retest then arb sepolia and solana devnet - it will be helpful for the developer if you could summarize what isn't working from all test cases on all networks in a single clear comment

@ae2079 I retested both Arbitrum Sepolia and Solana Devnet...based on this comment...thought those were the only two to be tested which I worked on.

If youre saying the rest are also ready then I will check them out as well and leave feedback on them here.

LatifatAbdullahi commented 2 months ago

@divine-comedian @ae2079

Test update

Base sepolia -projects count: Pass -donors count : Pass -donations count: Pass -total usd value donations count: Pass

Polygon zkevm cardona projects count : Pass donors count: Pass donations count:Pass total usd value donations count:Pass

Celo Alfjores projects count : Pass donors count: Pass donations count Pass total usd value donations count:Pass

LatifatAbdullahi commented 2 months ago

@divine-comedian

I need some test token to test Ethereum classic mordor network, I currently have 0.00002 and I cant donate with that as I do not have enough to pay for transaction fee image

LatifatAbdullahi commented 2 months ago

@divine-comedian @ae2079

dn

I have made multiple donations in Ethereum Classic Mordor Network, although they were successful, they all show pending here and also does not reflect in the Analytics board.

ae2079 commented 2 months ago

@divine-comedian now this feature is enabled in the production, so I think if there is no problem, we can consider it as Done.

divine-comedian commented 2 months ago

@LatifatAbdullahi - Can you test this feature out on production with Solana mainnet and ETC mainnet? I will provide you with some test tokens. If these two networks pass we should be able to call this done.