search

Giveth / feathers-giveth

Featherjs server for caching giveth data.
MIT License
87 stars 99 forks source link

F fix pan conversion rate #604

Closed mohammadranjbarz closed 2 years ago

mohammadranjbarz commented 3 years ago

related to #587, Giveth/giveth-dapp#2286

mohammadranjbarz commented 3 years ago

@aminlatifi I couldn't find any solution for PAN price, when coingecko dont return price in that range time, I just added some validations for /conversionRates endpoint , before user could send any invalid symbol and would get response , but I restricted the user input, and I think it's better to return 0 when we cant fetch PAN price, before we were sending 1.

but if you have any idea I can implement it ( I didn't find any good solution)