Audit-fixes - Githubissues

Giveth / giv-token-contracts

GNU General Public License v3.0

27 stars 8 forks source link

Audit-fixes #54

Open auryn-macmillan opened 2 years ago

auryn-macmillan commented 2 years ago

This PR implements fixes for some minor issues identified in an audit.

[x] removes jump at cliffTime
[x] eliminates griefiing attack vector on changeAddress
[ ] implements tests for the proposed changes

jfschwarz commented 2 years ago

Cliff vesting plans, as commonly offered for stock options, usually have that "jump" when hitting the cliff. So I think the original implementation is more intuitive.

auryn-macmillan commented 2 years ago

Cliff vesting plans, as commonly offered for stock options, usually have that "jump" when hitting the cliff. So I think the original implementation is more intuitive.

Yeah, after thinking about this more I actually think the original implementation is correct. initialAmount is just a somewhat novel feature that results in the potential for what is essentially two cliffs.