search

Giveth / giv-token-contracts

GNU General Public License v3.0
27 stars 8 forks source link

Obsolete version of OS on the server #98

Open aminlatifi opened 5 months ago

aminlatifi commented 5 months ago

The server we run the farming notify reward bot on runs with an obsolete OS version. It may have security vulnerabilities itself and also doesn't allow us to run updated versions of node.js. As we have to run our scripts with node v14 which is too old.

The server OS must be upgraded for its own security and won't be a blocker in the future for further development.

aminlatifi commented 5 months ago

@jainkrati

mhmdksh commented 5 months ago

@aminlatifi Can you dockerize this setup? So that we can easily migrate it?

CC: @geleeroyale once this is dockerized, we can easily set it up later

aminlatifi commented 5 months ago

It hosts two services, givpower-bot (production) and givfarm notify reward.

geleeroyale commented 5 months ago

thanks - we already moved the givpower-bot - we will migrate givfarm-notify after we hopefully fixed the current errors in prod

aminlatifi commented 5 months ago

I think it's better to finally to gelato service for these kind of things. Then we won't need to keep a server for these kind of stuff.

aminlatifi commented 2 months ago

The server we run the farming notify reward bot on runs with an obsolete OS version. It may have security vulnerabilities itself and also doesn't allow us to run updated versions of node.js. As we have to run our scripts with node v14 which is too old.

The server OS must be upgraded for its own security and won't be a blocker in the future for further development.

@geleeroyale @mhmdksh what's the final status of this? still notify reward is there?

geleeroyale commented 2 months ago

@aminlatifi I can not find a deployment or exact repo for givfarm-notify.

givpower-bot is already migrated as stated above

Can we take a look at this?

aminlatifi commented 2 months ago

@geleeroyale the repo is giv-token-contracts

geleeroyale commented 2 months ago

@aminlatifi I am sorry, but all I see in this repo are contracts and contract deployments for hardhat - I can't find any services

aminlatifi commented 2 months ago

@aminlatifi I am sorry, but all I see in this repo are contracts and contract deployments for hardhat - I can't find any services

There are scripts run every hour by cron job.

geleeroyale commented 2 months ago

@aminlatifi

I cloned the repo onto our services.giveth.io instance and tried for most of the day to get it to run - but whatever I do it won't work.

  1. not every file change has been tracked with git
    • all of the dependencies are outdated to a point that it all breaks

    • does not seem to run successfully on node14 but is set to node14 (I know its the point of this post but I am wondering why it still seems to work on the old system)

      after

    • manually creating some script files in /deployments,
    • updating package dependencies,
    • switching to yarn,
    • and many in-between experiments

I was able to run one of the cronjob scripts, but it fails with an error:

Image

It would be awesome if you could clean up the repository to a point of reproducability @aminlatifi - I can't run it in the current state.

aminlatifi commented 2 months ago

@geleeroyale Thanks for your effort so far. If you have prepared a safe server, I can work on make it run on that and solve issues. Wdyt?

geleeroyale commented 1 month ago

Do you have any update on this @aminlatifi - do you need support?

geleeroyale commented 1 month ago

@jainkrati This issue seems to be stuck because the deployment is totally outdated at this point. I was not able to correctly install and it seems like @aminlatifi also got stuck at some point.

My suggestion is to factor out givfarm-notify into its own repo and separate deployment

aminlatifi commented 1 month ago

@jainkrati This issue seems to be stuck because the deployment is totally outdated at this point. I was not able to correctly install and it seems like @aminlatifi also got stuck at some point.

My suggestion is to factor out givfarm-notify into its own repo and separate deployment

@geleeroyale Do we have a source document to tell us what is deployed where? If we have it, it would be super helpful since by looking at that we can better decide what must be deployed where.

mohammadranjbarz commented 1 month ago

@jainkrati This issue seems to be stuck because the deployment is totally outdated at this point. I was not able to correctly install and it seems like @aminlatifi also got stuck at some point.

My suggestion is to factor out givfarm-notify into its own repo and separate deployment

@geleeroyale Can you give me access to new server then I can deploy notify reward bot there

FYI @aminlatifi

geleeroyale commented 2 days ago

Access to server has been granted, please give an update on this @mohammadranjbarz