search

Giveth / giveconomy-foundry

GNU General Public License v3.0
29 stars 5 forks source link

make modifications for transferAllocation function #41

Closed divine-comedian closed 8 months ago

divine-comedian commented 10 months ago

change logic of cancelAllocation to add allocation balance instead of overwriting it.

divine-comedian commented 9 months ago

@jainkrati - this one needs a review to unblock me

jainkrati commented 9 months ago

Also can we make the Slither Analysis pass before we merge?

aminlatifi commented 8 months ago

@divine-comedian @jainkrati I did move the changes under the same contract name TokenDistro, since it's not trivial to change the contract name in the upgrade process. Also, made #43 to push latest version of production to develop branch, I think it's better to merge it first to the develop and then do the final comparison. BTW, I think the code is in good state now, just deleted an extra empty line.

aminlatifi commented 8 months ago

Thanks @divine-comedian for fixing the slither action, I just did a little change to make it work.

divine-comedian commented 8 months ago

@aminlatifi thanks! I reviewed this one, can you approve it then?

aminlatifi commented 8 months ago

@aminlatifi thanks! I reviewed this one, can you approve it then?

Approved