Giveth / giveconomy-foundry

GNU General Public License v3.0
29 stars 5 forks source link

Deploy TokenDistroV2 to Optimism & Gnosis Chain #42

Closed divine-comedian closed 1 month ago

divine-comedian commented 9 months ago

We need to deploy a new version of the token distro to both of these chains in the title, this will involved deploying the contracts then calling the upgrade to the proxyadmin to the proxy from the multisig on each chain.

Tasks

divine-comedian commented 8 months ago

@aminlatifi

Testing this out on OP Sepolia -

I assigned 0x62Bb362d63f14449398B79EBC46574F859A6045D as a distributor and gave it 1000 tokens to distribute

I allocated 10 tokens to 0x826976d7C600d45FB8287CA1d7c76FC8eb732030 then used transferAllocation to move it to 0x81443887E6Aef75de940B7244783f896B1c034Ca

it shows up correctly on the https://staging.giveth.io/givstream UI as 4.97 tokens claimable - I did not claim those tokens.

I allocated 10 tokens to 0x26135A4FC941828b063165c5C9311eF3bfeea4e5 then used transferAllocation to move it to 0x81443887E6Aef75de940B7244783f896B1c034Ca

the UI does not update - I should have ~9.9 tokens to claim now on the page

checking on the contract it says I have a balance of 20 tokens and claimableNow is ~9.9 tokens

I click claim from the UI and I claim 9.9 GIV tokens from the tokenDistro successfully. https://sepolia-optimism.etherscan.io/tx/0xd75983ce63016d3975fef9d727bd4ceea1eefc504df281d967f030a0077120e6#eventlog

This looks like an issue with the subgraph since the amounts on the contract appear to be correct.

aminlatifi commented 8 months ago

0x81443887E6Aef75de940B7244783f896B1c034Ca

Subgraph is correct, the frontend is merged as well and must be fine. @divine-comedian would you please check?

image
divine-comedian commented 8 months ago

Tested again with both transferAllocation and changeAddress functions and transferring allocations successfully added to each other instead of overwriting.

@aminlatifi what else needs to be done for deploying to production?

aminlatifi commented 8 months ago

Tested again with both transferAllocation and changeAddress functions and transferring allocations successfully added to each other instead of overwriting.

@aminlatifi what else needs to be done for deploying to production?

Good, in my view we can go.

divine-comedian commented 8 months ago

Noting here: