search

Giveth / giveth-dapp

Giveth Dapp for crowdfunding and managing donations on the ethereum blockchain.
https://beta.giveth.io
GNU General Public License v3.0
359 stars 230 forks source link

Cancel donation transaction cannot delete the record in feathers #1605

Open darcher-framework opened 3 years ago

darcher-framework commented 3 years ago

When I use Donation button to send a donation to DAC or Campaign, after the Ethereum transaction is sent by MetaMask, I can see one record in the detail page of DAC/Campaign, showing pending successful transaction.

At this time, if I use the functionality provided by MetaMask to cancel the transaction by sending another transaction which drop the previous one. The donation record is stuck here and showing pending successful transaction forever. But actually the donation transaction will never be executed since it has been dropped/cancelled.

I think it is a bug where I expect the donation record to be removed when I cancel the transaction. I test this using local chain and a screenshot is provided below. Screenshot 2020-12-24 at 16 08 07

aminlatifi commented 3 years ago

Thanks for creating this issue,

The feathers server deletes pending donation entities if they haven't gone through after a while. Provided that you use the latest version of feathers and dapp... the above picture is not for the latest giveth-dapp application.