Display of "People" on the campaigns page actually displays # of donations

[bowensanders]

Rather than give the correct number of "people" associated with a project, it seems that the number displayed as "people" is the number of donations to the project:

and then a couple minutes later:

Suggestion: Either change "people" to "donations" or change the code to display the number of people properly. Also possible is doing both, since it's a great undocumented feature! :)

[bowensanders]

I also wonder if the Donations / People issue is happening here too, on the milestones page for me:

In a message to Vojtech I mentioned that the numbers for donations were incrementing strangely, as you can see it says 011, 01, 0 - which leads me to believe that there is a variable acting like a string and not an integer, making N + 1 to be "01" and then N + 1 would then become "011"....

This is a pic from the campaign page. just for reference.

[vojtechsimetka]

I believe it is because we are adding two BigNumbets together. The BigNumbers are passed as strings to avoid precision loss.

[bowensanders]

I think that the top and the bottom are seperate issues. Should I split the second part (0-01-011) out to a new issue?

[satyavh]

You are absolutely right, these counters are wrong. Good catch.

We want to focus on the amount of people supporting the project, not the amount of donations. But this needs to be changed in feathers. I created a story for it: https://github.com/Giveth/feathers-giveth/issues/66

[vojtechsimetka]

The counters has been fixed in the feathers rewrite.