Giveth / giveth-dapp

Giveth Dapp for crowdfunding and managing donations on the ethereum blockchain.
https://beta.giveth.io
GNU General Public License v3.0
359 stars 230 forks source link

Archiving campaigns #2462

Open MoeNick opened 3 years ago

MoeNick commented 3 years ago

https://www.notion.so/giveth/Archived-Campaigns-6a074d87bdc14f0795195f4d6cea8ec6

mohammadranjbarz commented 3 years ago

@MoeNick we said we should not let anyone to edit archived campaign, do we allow to Cancel archived campaign or not?

MoeNick commented 3 years ago

I think we can ban cancelling, and let the owner to undo archiving and then able to cancel it. @mohammadranjbarz

mohammadranjbarz commented 3 years ago

I think we can ban cancelling, and let the owner to undo archiving and then able to cancel it. @mohammadranjbarz

@MoeNick Is it a final decision or just a suggestion? I think we should now allow campaign owner to unArchive, because if in some case for some reason admin archive campaign, but campaign owner can undo that, Maybe it's better to don't allow to edit archived campaign, or unArchive that, but it's ok to cancel that

mohammadranjbarz commented 3 years ago

@RamRamez plz read https://www.notion.so/giveth/Archived-Campaigns-6a074d87bdc14f0795195f4d6cea8ec6 we add a Archived status

PS : for archiving campaigns you should call /campaigns/{campaignId} PATCH and in body send {status:'Archived'} PS2: for undo archiving campaigns you should call /campaigns/{campaignId} PATCH and in body send {status:'Active'}

mohammadranjbarz commented 3 years ago

@RamRamez plz read https://www.notion.so/giveth/Archived-Campaigns-6a074d87bdc14f0795195f4d6cea8ec6 we add a Archived status

  • [ ] you should show a button to Admins and campaign owner to can Archive the campaign (Active campaigns could archive),
  • [ ] If a campaign is archived don't show edit button for that ( backend would not allow to edit that)
  • [ ] you should not show donate/delegate button for campaigns with status ( you can search disableDonate in your code, it's similar our case)
  • [ ] you should not show donate/delegate button for trace, if parent campaign of that trace has Archived status
  • [ ] Should show an unArchive button (@MoeNick what should be the text of button?) to admins and campaign owner

PS : for archiving campaigns you should call /campaigns/{campaignId} PATCH and in body send {status:'Archived'} PS2: for undo archiving campaigns you should call /campaigns/{campaignId} PATCH and in body send {status:'Active'}

@RamRamez This comment has been edited, please let me know if you had any question.

MoeNick commented 3 years ago

Text at the top of achieved campaign: "This campaign is archived. It no longer accepts funds." Text at the top of traces with achieved campaign: "Due to [campaign name] campaign is archived, This Trace no longer accepts funds." Text for button: "Archive" - "Unarchive" Note: a pop up needed for approving archive. as we have it in deleting or cancelling, needs 5 characters. Text of pop-up: "Archiving Campaign? {as title} By archiving this campaigns, it won't get listed and nobody can donate or delegate funds to it, nor its traces. Are you sure you want to archive this Campaign? Please enter the first 5 characters (without space) of the Campaign title while skipping any spaces: [Text Box] "

MoeNick commented 3 years ago

@WhyldWanderer appreciate if you can confirm the wording and grammar of the above ^^ @RamRamez : FYI

WhyldWanderer commented 3 years ago

My suggestions: Text at the top of archived campaign: "This campaign is archived and no longer accepts funds." Text at the top of traces under archived campaign: "Because [campaign name] campaign is archived, this Trace no longer accepts donations." Text for button: "Archive" - "Unarchive" Text of pop-up: "Archiving Campaign? {as title} By archiving this campaign, it will no longer be listed and will be unable to accept future donations or delegations. Any TRACES listed under this campaign will be archived as well. Would you like to proceed?" If you are sure you want to archive this Campaign, please enter the first 5 characters (without spaces) of the Campaign title. [Text Box] "

MoeNick commented 3 years ago

Error msg over delegating to parent archived trace: {Campaign Name} Campaign is archived. You can't delegate to this campaign nor its Traces.

MoeNick commented 3 years ago

I made another issue and move this to done.

MoeNick commented 3 years ago

@mohammadranjbarz @RamRamez Admin can archive and unarchive Campaign Owner should only archive

RamRamez commented 3 years ago

@MoeNick

Please send me the new message that we are gonna show when user Archive/UnArchive.

image

RamRamez commented 3 years ago

And this is UnArchive message:

image

MoeNick commented 3 years ago

Are you sure you want to archive this campaign? It can be reactive again by Giveth Admin only. @RamRamez

WhyldWanderer commented 3 years ago

image

Should say: "Archive Campaign? By archiving this campaign, it will no longer be listed and will be unable to accept future donations or delegations. Any TRACES listed under this Campaign will be archived as well. This action can only be reversed by an a Giveth admin. Would you like to proceed?"