Giveth / giveth-dapp

Giveth Dapp for crowdfunding and managing donations on the ethereum blockchain.
https://beta.giveth.io
GNU General Public License v3.0
358 stars 230 forks source link

F 2544 ability to withdraw any tokens bigger than withdraw limit #2549

Closed RamRamez closed 2 years ago

RamRamez commented 2 years ago

Issue #2544

netlify[bot] commented 2 years ago

✔️ Deploy Preview for giveth-dapp ready!

🔨 Explore the source changes: 9b92119315ace98386b66bec0049c3125dd7eb3f

🔍 Inspect the deploy log: https://app.netlify.com/sites/giveth-dapp/deploys/61535bcda58db900073e480d

😎 Browse the preview: https://deploy-preview-2549--giveth-dapp.netlify.app/

mohammadranjbarz commented 2 years ago

@RamRamez You didnt handle withdraw when user want to withdraw from /my-traces

Screen Shot 1400-07-06 at 17 03 25
mohammadranjbarz commented 2 years ago

@RamRamez @MoeNick For when we can just withdraw one token, is this sentence ok ? Select tokens to withdraw this message has mislead me as a user

Screen Shot 1400-07-06 at 17 05 28
MoeNick commented 2 years ago

Do you have any suggestion @mohammadranjbarz ?

RamRamez commented 2 years ago

@mohammadranjbarz When there is only one token to withdraw, that token is selected by default and select component is disabled. I can remove select component in this case and put just a text instead

mohammadranjbarz commented 2 years ago

Do you have any suggestion @mohammadranjbarz ?

Something like this : You just can withdraw your withdrwableToken tokens,

PS : Amin told me review this PR, so I said my suggestions, but if you think it's ok we can leave it as it is

mohammadranjbarz commented 2 years ago

@mohammadranjbarz When there is only one token to withdraw, that token is selected by default and select component is disabled. I can remove select component in this case and put just a text instead

I think it's good, @MoeNick What do you think about it?

RamRamez commented 2 years ago

@RamRamez You didnt handle withdraw when user want to withdraw from /my-traces

Screen Shot 1400-07-06 at 17 03 25

Yes you're right. I fixed it.

mohammadranjbarz commented 2 years ago

@RamRamez You didnt handle withdraw when user want to withdraw from /my-traces

Screen Shot 1400-07-06 at 17 03 25

Yes you're right. I fixed it.

It's ok now but I get an error when want to disburse money (When I have just one token in my trace collect is ok) Screen Shot 1400-07-07 at 09 42 04 (2)

RamRamez commented 2 years ago

@mohammadranjbarz I simulated the same situation and it was ok for me. Maybe it was a MetaMask error or something. Can you test again?