Need to fix release so that we can test payments

[bowensanders]

It would be a great feature if when disburseAuthorizedPayment(s) is triggered, and a payment moves from Pending to Paid in the bridge monitor, that the system generates an email to notify the recipient that their payment has been sent.

[loietaylor]

despite how nice the personal messages are...yup, this would be awesome! that way the days of bowen and i awkwardly chasing down ppl's reward daos and finding them on riot are over :-)

[ewingrj]

it wouldn't really work for reward dao b/c they aren't registered in the dapp, so we wouldn't know an email to send to

[bowensanders]

Maybe not directly, but when Loie and I were doing it all by hand (with the multisend and all) we were able to cross-reference addresses with a list we had. So I suggest one of two things:

1) If the address is registered to a user, email them, If it is not registered to a user in the dapp, check a google sheet (or make a way to register the addresses) 2) Can't we cross-reference "wall of fame" eth addresses and identities / emails?

It seems like either is inherently possible, and it would solve both the regular rewards and reward dao conditions, and people would get notified on payout automatically.

[ewingrj]

If you want to cross reference google sheets or something else, then this should not be in the dapp, but should be an outside service that is run for the reward DAO or whatever.

[vojtechsimetka]

@bowensanders I think you could tackle this one. All you need to do is modify the Bridge monitor feathers service to send email when the payment status changes to "Paid" for the first time. You already have the milestone info in the bridge now so you can find emails of the Milestone Managers. Have a look at bridgemonitor/feathers/services/payments. I'm happy to help if needed :).

[Danibelle]

In looking toward having Reward DAO recipients create their own milestones, that will solve the email address issue and keep this in the DApp, right?

Are you interested in taking this on @bowensanders ? I'm interested in helping prioritize and clean up open issues that touch Reward DAO so we can document the process from points to paid :)

[bowensanders]

I've currently got my fingers in the code for the bridge monitor, and I need to look into the feathers section of it to find out how it works to do this, so the short answer is yes, I am interested in taking this on as I've already got a bunch of things in there i'm working on - but I'm not sure how quickly it will be done, but my guess is within a couple weeks. Once I have a slightly better idea in the next couple days I will update here

[arbreton]

@bowensanders is this still open or can we close it?

[bowensanders]

This has not been addressed as I never got as far as tracking it down at all. I may need to excuse myseld from fixing this one if someone else wants to tackle it before I get the chance - I remember RJ / Vojtech telling me where the problem would be. I do want to say now that the bridge monitor dashboard links identities to the addresses of payment recipients, it should be a lot easier since that code is already written.

[GriffGreen]

needs to be done with the bridge... doesnt look that hard.... maybe Bowen and Andre/Jorge can work on this

[GriffGreen]

This is soooo coool! Its getting closer, :-D @bowensanders can you schedule a time with @arbreton

[GriffGreen]

@arbreton what is up with this... did it work?

[arbreton]

I have created https://github.com/Giveth/giveth-bridge-monitor/tree/f_paid_emails but this issue got stale due to the workload at that time, Is pending to test this on https://release.giveth.io/, https://bridge.release.giveth.io/ there is tx #13 that needs to be disbursed by the security guard in order to test the email

[bowensanders]

I'm having a time of getting that version of the bridge monitor to use metamask properly so i am unable to disburse through the monitor page. I am going to try to load the mainnet ABI into MyCrypto to see if i can directly interact with the contract on ropsten (I'd be using the etherscan contract interactions but whomever deployed the ropsten contract didn't upload the source code for verification and so I can't) I'll update as soon as I find a workaround

[bowensanders]

I need the actual contract address for the Ropsten (main) bridge contract.

Using 0xC59dCE5CCC065A4b51A2321F857466A25ca49B40 doesn't work no matter how hard I try, so i think my information is incorrect.

[bowensanders]

After working with some others on this we discovered that I'm not the security guard on that ropsten contract: 0xe82435C4f8B8Be65Dc47FEBB0FB97Fedf9e8C453 is.

[

](url)

[bowensanders]

i believe that is also the deployer of the contract on ropsten. so there's the problem! If we have access to that key, we can work this out

[arbreton]

That's very good to know @bowensanders thank you very much, I think we can look into an alternative, in this case, maybe we will need to create another environment or test it directly on beta, we can definitely take a look at this on Thursday with @aminlatifi, I will take notes of this

[bowensanders]

Just let me know, hopefully with a little bit of warning, when i need to do a thing, and i'll be there to help test it

[aminlatifi]

@GriffGreen I have turned down release services because there are hosted in the same machine hosts multiple services and it doesn't have enough resources.