Option to delete draft projects

[laurenluz]

I have so many sketchy test drafts in "my projects" with no clear way to get rid of them? Can we add a little trashcan w/ an "are you sure?" modal please?

@mosaeedi @MoeNick

[divine-comedian]

Add Delete Project as option for actions menu when project is in draft mode.

We should add a confirmation modal ARE YOU SURE YOU WANT TO DELETE YOUR PROJECT?

[laurenluz]

omg guys this is getting painful... @divine-comedian @mosaeedi

there was an update to "My projects" where now the projects info takes up so much more space on the page...

and I still can't delete all the useless drafts which all appear FIRST. above my very legitimate projects.. Giveth & the matching pool.

so "my projects" is just now a total mess for me, and I'm sure I'm not the only one.. can we please prioritize this issue?

https://github.com/Giveth/giveth-dapps-v2/assets/75490971/50e77d00-9326-42ae-9a6e-326a77e1b2e6

[mosaeedi]

Link to Figma

When a project is in draft mode, the Delete Project option should be added to the action dropdown.

And when users click the Delete option, we need to make sure they know what they are doing with a confirmation modal.

[divine-comedian]

This looks great! I made https://github.com/Giveth/impact-graph/issues/1519 to follow up making the back-end endpoint for this before proceeding with FE

[laurenluz]

you guys are amazing <3 thank you

[MohammadPCh]

@mohammadranjbarz Do we have an API to delete draft projects?

[mohammadranjbarz]

@mohammadranjbarz Do we have an API to delete draft projects?

No we don't have any API for deleting projects (draft or non-draft) @divine-comedian @laurenluz if we need it, please create an issue for that

[divine-comedian]

This looks great! I made Giveth/impact-graph#1519 to follow up making the back-end endpoint for this before proceeding with FE

@mohammadranjbarz - issue was made here about 2 months ago, but it was never assigned to anyone :sweat_smile:

[mohammadranjbarz]

This looks great! I made Giveth/impact-graph#1519 to follow up making the back-end endpoint for this before proceeding with FE

@mohammadranjbarz - issue was made here about 2 months ago, but it was never assigned to anyone 😅

[MohammadPCh]

@mohammadranjbarz Is there any new update for it?

[mohammadranjbarz]

@mohammadranjbarz Is there any new update for it?

I just assigned it to @Reshzera , he will let you know here when implemented and merged

[divine-comedian]

@MohammadPCh - @Reshzera has implemented the BE endpoint, Is there another FE dev we can pass this to?

@Reshzera please share any details on accessing the endpoint

[divine-comedian]

the backend has been merged in https://github.com/orgs/Giveth/projects/9/views/1?filterQuery=+status%3Adone+is%3Aopen+-label%3AStellar&pane=issue&itemId=68913749

Since Rafael is no longer here we will need to find the endpoint and how to integrate it in the FE to allow draft projects to be deleted. @kkatusic pick this one up whenever you have time.

[kkatusic]

@divine-comedian, I will take it, thx

[kkatusic]

@laurenluz, cc @divine-comedian, we have problem with environment variable, after investigation @mhmdksh fixed. You can try to check change on staging domain.

[LatifatAbdullahi]

Test Update

When project status is "Draft", the "Delete Project" option is present - Pass

When Project status is "Active" the "Delete Project" option is absent - Pass

@kkatusic

Functional issue

However, I am unable to complete the delete process, as no action is taken after clicking on the "Delete Project" button

https://github.com/user-attachments/assets/620d46ed-56fc-47bf-93da-1d83478ac5db

UI issue

From the design above, the "Project name" should be bold as well. The colour of the button should be Red not Pink The button width should be 300px as per the design

[kkatusic]

@LatifatAbdullahi this function for delete is missing from code I'm investigating :)

[laurenluz]

hey guys, this issue is on prod, but it's not working, see recording... @kkatusic

https://github.com/user-attachments/assets/b44ba249-6f99-4fd8-b129-7ea70bb21bcc

[divine-comedian]

@kkatusic @LatifatAbdullahi I'm not sure this feature passed QA - so how did it end up in production?

[LatifatAbdullahi]

@divine-comedian

Last time this was tested, the delete action failed and it was still being investigated, that's why its still open.

[divine-comedian]

OK but the code - which doesn't work - has been pushed to production, so now this is a problem that we have to focus on fixing and push a hotfix..

[kkatusic]

OK but the code - which doesn't work - has been pushed to production, so now this is a problem that we have to focus on fixing and push a hotfix..

no code pushed, just environment variable: NEXT_PUBLIC_DELETE_PROJECT_ENABLED let ask someone to setup it to false

[kkatusic]

@laurenluz, cc @divine-comedian, when you get time can you please check on production side is that option removed? thx

[laurenluz]

remove from prod

[divine-comedian]

Thanks @kkatusic so we'll continue work on staging for the remaining bugs that @LatifatAbdullahi reported above https://github.com/Giveth/giveth-dapps-v2/issues/1271#issuecomment-2332167850

[maryjaf]

If you are busy with unicorn tasks , I can take this issue @LatifatAbdullahi

[maryjaf]

Now the "delete" option is only shown in my project list, shouldn't this option also be shown in project page ? like as continu creation button a button there should be for delete? @mosaeedi @divine-comedian

[divine-comedian]

thanks @maryjaf - its a good suggestion but this feature isn't a high priority - I've made a new issue to follow up adding the button on the project details view, if all other tests pass we can call this issue done and follow up in the issue https://github.com/Giveth/giveth-dapps-v2/issues/4838