Incorrect wallet address in GIVbacks email

[clara-zi]

Pasting copy of email query "I'm getting emails that say: Your Round 19 GIVbacks have been distributed and are ready to claim! Thank you for participating in the GIVeconomy and for making the world a better place for all! All GIVers that donated $10 or more cumulatively to any verified projects during Round 19 are also eligible to claim a POAP! (connect your address 0xad7575aefd4d64520c3269fd24eae1b0e13dbe7b to claim) ...but I don't own/recognise the address 0xad7575aefd4d64520c3269fd24eae1b0e13dbe7b"

[clara-zi]

Checked in etherscan - address appears to belong to a project owner with a portfolio of 2 projects on platform, however address is not used for either project. To check: 1) is set-up for mail merge correct in AutoPilot? 2) is there a any connection between this wallet address and the person emailed.

[MoeNick]

I mention you here cause you are our autopilot and support hero. @CarlosQ96

[CarlosQ96]

@clara-zi I need a bit more details, what project/user-address/emails are the correct ones that received donations on giveth? to investigate further.

I looked up in the database the address 0xad7575aefd4d64520c3269fd24eae1b0e13dbe7b it has an empty user created (no email, no info) which is weird. But at the same time I found no projects with said address or any project related to this user.

My suspicion is a certain piece of data overlapped that later was changed, most likely the address (in uppercase), as I see this user is quite old.

I need more info to investigate better, the connection between the wallet and the person that mailed.

Regarding autopilot, I am not sure how givbacks emails are sent atm. I'll ask @divine-comedian or @WhyldWanderer

[divine-comedian]

also noticing issues with https://github.com/Giveth/giveth-planning/issues/976#issuecomment-1290314132 that seems to be related with autopilot or potentially segment sending wrong information

[ahmadabugosh]

Hey team, I have an update on this issue

[CarlosQ96]

sent a list to @ahmadabugosh and @WhyldWanderer regarding all users that have donated so we can check any difference.

[MoeNick]

Is there any update @CarlosQ96 ?

[CarlosQ96]

@ahmadabugosh has this issue ocurred again after I passed you the CSV?

I have not found the root cause, but want to know.

[ahmadabugosh]

Hey @CarlosQ96 ,

It seems to be fixed for most cases, but sometimes I still notice weird behavior. One case that I think we should look into that is still confusing me is @GriffGreen's wallet: 0x839395e20bbb182fa440d08f850e6c7a8f6f0780

I changed his Donor wallet before in Autopilot to "griff @ giveth.io", but it keeps getting set back to @franculio 's email: "franculio.ruiz @ gmail.com"

Can you look into this case? The only thing I can think of is maybe the Giveth house project is changing his Donor Wallet Address and Project Wallet Address at the same time and setting the same email for both?

[ahmadabugosh]

Hey @CarlosQ96 , here are a few more I noticed that were wrong in GIVbacks round 33. I mentioned what the email should be and what they showed up as in Autopilot. I already fixed them so I could send the GIVbacks email, but I still don't know what the cause is: https://docs.google.com/spreadsheets/d/1nXT83E__MHY3Lj8wpXNmOyZ4z60KARykrR3e6rqwnlg/edit#gid=0

[CarlosQ96]

Thankss @ahmadabugosh ill be checking this cases to find the issue

[ahmadabugosh]

@CarlosQ96 I just added the ones I noticed were wrong in GIVbacks round 34 in Autopilot as well: https://docs.google.com/spreadsheets/d/1nXT83E__MHY3Lj8wpXNmOyZ4z60KARykrR3e6rqwnlg/edit#gid=267683724

[ahmadabugosh]

Hey @CarlosQ96 There were 3 wrong ones in this round too: https://docs.google.com/spreadsheets/d/1nXT83E__MHY3Lj8wpXNmOyZ4z60KARykrR3e6rqwnlg/edit#gid=107192263

Did you get a chance to investigate?

[laurenluz]

has this been fixed yet? @CarlosQ96 ?

[MoeNick]

@CarlosQ96 pls let us what to do with this one.

[divine-comedian]

We will need to manually check each call to the notification center, data sent to the wrong place

Need to check each email flow and each flow in autopilot

Mitch thinks its somewhere in our Segment integration into Autopilot - certain flows causing information to be overwritten incorrectly.

[MoeNick]

@divine-comedian do yu want Segments autopilot issues to be resolved in DApp WG? if so, we need to onboard a person. if not, we can move it to planning repo for comms.

[divine-comedian]

@divine-comedian do yu want Segments autopilot issues to be resolved in DApp WG? if so, we need to onboard a person. if not, we can move it to planning repo for comms.

Yup let's deal with it in dApp! As we chatted about then maybe @RamRamez @CarlosQ96 and @ahmadabugosh can work on these issues?

[MoeNick]

Can I put it inside Ortto Migration? if not, how do we want to deal with it? P1? @divine-comedian

[ahmadabugosh]

@MoeNick I think the Ortto migration should fix it, because we would no longer be relying on the Segment event (which I think was causing this issue in the first place)

[MoeNick]

OK I put it inside ortto epic to test the validity of GIVbacks email later.

[MoeNick]

@RamRamez @divine-comedian Did we implement the GIVbacks emails as well? SHall I put it in UAT?

[RamRamez]

@MoeNick It's easy to implement but it wasn't part of the email migration epic, so we don't have it right now. We only add GIVbacks round tag for each user donated on that round.

[divine-comedian]

No @MoeNick - the GIVbacks email is handled manually by @WhyldWanderer when the round analysis is finished, which can be an arbitrary time - it is not something triggered by our app