Closed laurenluz closed 2 months ago
@aminlatifi - The GIV/USDGLO pair was set up on Uniswap v2 on OP Mainnet.
Are you sure? do you have any sample swap tx? or pool address? I couldn't find any!
@aminlatifi on these:
- the $ should be before the number (not after)
- can you also should the TVL amount in GIV - maybe show this number below/smaller?
Changed the $ position. No, the component doesn't support that! we must create another counter if we need
@aminlatifi - The GIV/USDGLO pair was set up on Uniswap v2 on OP Mainnet.
Done, now all optimism uniswapV2 pools will be supported automatically.
Ok aweomse. Griff mentioned also last time that we should show the % of the TVL that is "DAO owned" - Do you need some guidance on how to do that @aminlatifi ?
A lot that liquidity that we have, the LPs are held by the liquidity multisig on various chains. I think we can consider that all to be "DAO-owned", and then the GIV that we bridged to Solana and provided liquiidty with... I think Griff might hold those LP tokens, but that's the only weird one I can think of.
Ok aweomse. Griff mentioned also last time that we should show the % of the TVL that is "DAO owned" - Do you need some guidance on how to do that @aminlatifi ?
A lot that liquidity that we have, the LPs are held by the liquidity multisig on various chains. I think we can consider that all to be "DAO-owned", and then the GIV that we bridged to Solana and provided liquiidty with... I think Griff might hold those LP tokens, but that's the only weird one I can think of.
Do you know on which pools DAO has liquidity? it matters since for example computation would be different for uniswap and balancer. If all are uniswapv2 it probably would be simple. But other ones like uniswapv3 and balancer I am afraid not.
I think it's going to get too complicated and we can skip it. Went through this once more with Griff, and got some final comments/change requests.
Omg and I think that should be it.
Ok @aminlatifi so to summarize, there are 5 query changes that we need:
Ok @aminlatifi so to summarize, there are 5 query changes that we need:
- [x] GIV balance holders "all chains" pie chart should be changed to show only a % number with the title "% of Circulating Supply Held by the DAO"
- [x] GIVpower section "% of total supply that is locked" should actually show the "% of Circulating Supply that is Locked"
- [x] % of GIV Total Supply that is staked should be "% of GIV Circulating Supply that is staked"
- [x] % of GIV Total Supply that is locked for at least 6 more months" should be "% of GIV Circulating Supply that is locked for at least 6 more months"
- [x] There is a mistake in GIV unlock times chart! Some people definitely are locking until Jun 2025 on OP Mainnet, but the chart is not saying they are (see my image above of my lockup dates)
These are done, @laurenluz please double check.
There is a mistake in GIV unlock times chart! Some people definitely are locking until Jun 2025 on OP Mainnet, but the chart is not saying they are (see my image above of my lockup dates)
I fixed that, The Optimism givpower contract has a different init date than the gnosis one and I didn't know. Fixed that issue in the below diagram as well.
@aminlatifi - I removed the pie chart for % of GIV held by the DAO and replaced it with just a number instead. I think I did this right! Lmk if it looks ok? I just added a new visualization to your query, then deleted the pie chart and add the counter to the dashboard.
Before:
After:
Also, on these three numbers... Shouldn't they add to a total of 1 Billion? They actually add to a bit more than that, I think we might be double counting somewhere - can you check?
@aminlatifi - I removed the pie chart for % of GIV held by the DAO and replaced it with just a number instead. I think I did this right! Lmk if it looks ok? I just added a new visualization to your query, then deleted the pie chart and add the counter to the dashboard.
Before:
After:
Also, on these three numbers... Shouldn't they add to a total of 1 Billion? They actually add to a bit more than that, I think we might be double counting somewhere - can you check?
That counter is fine.
They had different query execution time, I refresh them all now the tally match
EXCELLENT!!!!! Ok I'm asking for feedback from others on this, but from my view, this is GREAT!!! THANK YOUUUUUUUUU
Feels like a MAJOR achievement to close this issue https://dune.com/giveconomy/giveconomy
Praise you @aminlatifi !!
We have this awesome GIVeconomy dashboard that was made by Fabio, but it is very out of date: https://dune.com/metacrypto/giveconomy
It would be great to fork this dashboard & add to it so that we can show GIV liquidity on multiple chains, and show what is owned by the DAO, and what is provided by individuals.
Would be great to show:
This would be valueable to show to people who are interested in GIV & its stability. (like investors)
@RamRamez
It would be nice to build in dune because it uses on chain data, and then has network effects - it can easily be forked and used by others.