Make it possible to "Boost" non-verified projects with GIVpower

Giveth / giveth-dapps-v2

This project is the aggregation of GIVeconomy and Giveth.io DApps in a single repo

https://staging.giveth.io

GNU General Public License v3.0

61 stars 34 forks source link

Make it possible to "Boost" non-verified projects with GIVpower #3667

Open laurenluz opened 7 months ago

laurenluz commented 7 months ago

The logic (math conditioned by project verfied status) is hard coded in SQL Queries and Procedures.
E.g. below SQL queries are part of the logic we have pushed to DB to calculate ranks
We have also some queries in the impact-graph code which are executed per query, they also must be modified.

https://github.com/Giveth/impact-graph/blob/staging/migration/1662915983385-ProjectPowerView.ts https://github.com/Giveth/impact-graph/blob/staging/migration/1683191367806-CreateProjectInstantPowerView.ts

The above is a summary of points from my chat w/ @aminlatifi

The Tl;Dr is that it's possible to make this happen, but the changes are critical so we need to go slow & then this will require a lot of testing on staging in order to make sure we don't break anything.

MoeNick commented 7 months ago

Is it part of post-MVP QF epic?

laurenluz commented 7 months ago

no, this isn't directly related to QF. more GIVeconomy side. I will include it in the GIVeconomy WG proposal

MoeNick commented 7 months ago

I put p2 for this, correct me if I was wrong @laurenluz

laurenluz commented 7 months ago

hmm well this is blocked by the decisions we make in this forum post: https://forum.giveth.io/t/changing-what-verified-means-on-giveth/1300/5

I would just hold off on prioritizing it until we decide if/when we are doing it at all.

jainkrati commented 5 months ago

is this still blocked on the forum post @laurenluz

laurenluz commented 4 months ago

this is blocked by us building & implementing the decentralized verification process with attestations....

but if we are able to do preliminary work on it... like creating the two separate tags in the backend "verified" and "givbacks eligible" and then broading our system to handle both... I think we can go for it and even move to dev research!

@jainkrati I think Amin would be a great person to handle it.

laurenluz commented 4 months ago

if we need to discuss it more or the requirements are not clear let me know and I can expand upon this issue or we can discuss in the GIVeconomy call.

divine-comedian commented 1 month ago

@laurenluz - do we want to redefine this issue as we work on decentralized verification and the new status changes for projects?

laurenluz commented 1 month ago

yes definitely, this should be iceboxed until the requirements are clear

divine-comedian commented 1 week ago

@laurenluz I think @MohammadPCh has made this possible on the BE and @mohammadranjbarz needs to implement the corresponding givbacks-calculation changes