search

Giveth / giveth-dapps-v2

This project is the aggregation of GIVeconomy and Giveth.io DApps in a single repo
https://staging.giveth.io
GNU General Public License v3.0
61 stars 34 forks source link

"Flip" GIVbacks - most GIVbacks should go out on Optimism, only gnosis donations get GIV on gnosis #4181

Closed laurenluz closed 2 months ago

laurenluz commented 4 months ago

As discussed in the last GIVeconomy call, we want to move GIVbacks more onto Optimism network.

So that only donations from gnosis get GIVbacks on Gnosis. And donations on all other eligible chains, get GIVbacks on Optimism.

cc @WhyldWanderer @divine-comedian @GriffGreen @jainkrati

WhyldWanderer commented 4 months ago

Thanks for making the issue Lauren.

I want to emphasize the importance of not springing this on donors in the middle of a round. We should announce it before we start and have it start at the beginning of a round rather than in the middle.

I plan to put information about it in the upcoming GIVbacks forum posts so that people are aware that we are working on changing how it works..

laurenluz commented 4 months ago

@mohammadranjbarz do you think we'll be able to deliver this by the start of the next round Tuesday May 28?

mohammadranjbarz commented 4 months ago

@mohammadranjbarz do you think we'll be able to deliver this by the start of the next round Tuesday May 28?

@laurenluz Yeah I try to do it, but we should hold on and don't merge till @WhyldWanderer give us approval to merge it

mohammadranjbarz commented 4 months ago

It's implemented on https://github.com/Giveth/giveth-dapps-v2/issues/4181#issuecomment-2124192706, but we just can merge it after @WhyldWanderer tell us

FYI @divine-comedian @laurenluz

jainkrati commented 3 months ago

lets merge and close this @mohammadranjbarz

mohammadranjbarz commented 3 months ago

lets merge and close this @mohammadranjbarz

ّI think we should wait till @WhyldWanderer tell us merge it, because Ashley wants to have this feature after distributing previous givback rewards

WhyldWanderer commented 3 months ago

Yes please! I will let you know when we have the green light to merge it.

We still have a couple rounds to distribute first. Thanks Krati & Mohammad!

jainkrati commented 3 months ago

let us know when we should proceed @WhyldWanderer

WhyldWanderer commented 2 months ago

This is now ready for implementation @mohammadranjbarz @jainkrati

mohammadranjbarz commented 2 months ago

This is now ready for implementation @mohammadranjbarz @jainkrati

Thanks @WhyldWanderer I merged/deployed it, please let me know if you found something incorrect

WhyldWanderer commented 2 months ago

I finished the calculation today and everything looks accurate!

Great job guys <3

I think we can close this one now