Giveth / giveth-dapps-v2

This project is the aggregation of GIVeconomy and Giveth.io DApps in a single repo
https://staging.giveth.io
GNU General Public License v3.0
61 stars 34 forks source link

Add More Actions to Actions menu on my projects page #4199

Closed divine-comedian closed 1 month ago

divine-comedian commented 3 months ago

When a user is visiting the 'my projects' page they should be able to easily find the verify project button. They should also be able to deactivate and activate their project as well from this same actions menu image

Acceptance Criteria | AC

On the Action bar for the project card we should handle the following:

cc: @WhyldWanderer

kkatusic commented 3 months ago

@divine-comedian just to notice you, I'm half done, for other half will ask @MohammadPCh what is best practice to do inside code enable activation/deactivation.

verify_project

MohammadPCh commented 3 months ago

@kkatusic I'll dm you.

divine-comedian commented 2 months ago

@MohammadPCh @kkatusic What is the update on this issue?

kkatusic commented 2 months ago

@MohammadPCh @kkatusic What is the update on this issue?

@MohammadPCh and I will check that on Monday, I push working branch, all function are there but having issue changing state for activating and deactivating project.

maryjaf commented 2 months ago

This issue could be assigned to Latifat as a first task

divine-comedian commented 2 months ago

@LatifatAbdullahi

To test this issue you'll need to create a project on Giveth staging

For determining the expected behaviour you can confirm with @maryjaf on what happens when a project becomes deactivated/activated and how it should handle being forwarded to the project verification form depending which new button you are testing.

Also don't forget to review and approve the acceptance criteria I've posted in the original comment on this issue

LatifatAbdullahi commented 2 months ago

Sure! On it

kkatusic commented 2 months ago

@LatifatAbdullahi if you need help for first time be free to contact me

LatifatAbdullahi commented 2 months ago

Noted, thank you

On Thu, 27 Jun 2024, 11:59 kkatusic, @.***> wrote:

@LatifatAbdullahi https://github.com/LatifatAbdullahi if you need help for first time be free to contact me

— Reply to this email directly, view it on GitHub https://github.com/Giveth/giveth-dapps-v2/issues/4199#issuecomment-2194386740, or unsubscribe https://github.com/notifications/unsubscribe-auth/A2YPQ6WGPV7NQXL4YSNB23TZJPWA7AVCNFSM6AAAAABID63TE2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJUGM4DMNZUGA . You are receiving this because you were mentioned.Message ID: @.***>

LatifatAbdullahi commented 2 months ago

@divine-comedian

Test completed Test Status: Passed

When a project's verified status is "Not Verified", an option called "Verify project" is seen which leads to the verification page. Verify Project

When a project is Verified, Users are able to deactivate their projects successfully. Also they are able to activate back after deactivation.

With regards to the Acceptance Criteria relating to the Project card Action bar;

-When a project's verified status is "Not Verified", an option called "Verify project" is seen which leads to the verification page.

-When a project's verified status is 'Incomplete' there is an option called "Resume Verification " which this leads to verification page. ResumeVerification

When project's status is Active there is an option to deactivate their project

nm

When Project's status is Deactivated there is an option to activate their project

last

-Users are able to perform all necessary actions as expected in the Project card action car.

av jk

divine-comedian commented 2 months ago

@LatifatAbdullahi - could you also confirm, when a project is not verified that you also see a Verify Project button on the drop down menu on the project card? image

LatifatAbdullahi commented 2 months ago

@divine-comedian Sure! A non-verified project

nn

kkatusic commented 2 months ago

Nice, look @MohammadPCh we passed :)