FE changes to show recurring donations for QF

[divine-comedian]

Some FE changes should be made that show this recurring donation be in a QF round like in donate page and donation success page

Originally posted by @maryjaf in https://github.com/Giveth/giveth-dapps-v2/issues/3284#issuecomment-2122543938

On the donate page for recurring donations - if the project is in a QF round and optimism is an eligible network for the current QF round we should show the QF related project card on the side instead of the regular card.

On the success page we should show the section related to QF matching on this view as well.

[maryjaf]

• [ ] It would be good if we consider this scenario

• The project hasn't any one time donation in a round

• The project has a recurring donation and it be counted in estimated matching

• The project card is shown like below pic, amount raised in this round is 0 , estimated matching is more than zero (because of recurring donation in the round)

cc: @divine-comedian @MohammadPCh

[divine-comedian]

nice catch MJ! So the value of the recurring donation is not being considered in the "amount raised this round" field on the project card when the project is inside of an active QF round.

We should count the value of eligible recurring donations made inside the QF round to the given project and include it in this number.

@MohammadPCh I can make a new issue if you prefer or track it here

[MohammadPCh]

@divine-comedian Yes, please create a new issue :D

[divine-comedian]

@maryjaf I created a new issue for the scenario you reported - #4287

Can you confirm if the original parts of this issue are completed?

[maryjaf]

like in donate page and donation success page

Donate page:

• [ ] 1- There is difference between one time and recurring tab for project in a round, please take a look @MohammadPCh

https://github.com/Giveth/giveth-dapps-v2/assets/111529185/63711a1c-2a86-4ab0-8c54-4b9f9f042d0f

• [ ] 2- Estimated matching isn't shown in recurring donation tab

https://github.com/Giveth/giveth-dapps-v2/assets/111529185/011ba277-f7ef-4019-81a5-676a67e8924b

Donation success page:

There is no problem in donation success page

[divine-comedian]

I don't think we defined how to get the estimated matching for a recurring donation...

My guess to do the estimated matching we would need to know

1. How many seconds are left in the QF round
2. How much the user is proposing to donate per second

Then we would need to take the seconds left in QF round, multiplied by amount to donate per second, this would become the value we use for the estimated matching.

[maryjaf]

I don't think we defined how to get the estimated matching for a recurring donation...

My guess to do the estimated matching we would need to know

1. How many seconds are left in the QF round
2. How much the user is proposing to donate per second

Then we would need to take the seconds left in QF round, multiplied by amount to donate per second, this would become the value we use for the estimated matching

I don't get it correctly , so this behavior is expected or it should be changed

• [ ] 1- There is difference between one time and recurring tab for project in a round, please take a look @MohammadPCh
• [ ] 2- Estimated matching isn't shown in recurring donation tab

[divine-comedian]

Oh, the 1st issue looks to be a bigger issue, not related to this issue - I would consider it out of scope here and we can follow it up elsewhere and see how Lauren wants to handle it.

The second issue however - looks like the QF project card hasn't been implemented for recurring donations yet.

[MohammadPCh]

@divine-comedian can we close this issue? or wrap up the remaining tasks?

[divine-comedian]

@divine-comedian can we close this issue? or wrap up the remaining tasks?

Did you resolve the second issue MJ reported? The QF version of the project card should show up when user selects to make a recurring donation from donate page

[MohammadPCh]

@lovelgeorge99, could you take care of this and resolve this old issue? Thanks!

[lovelgeorge99]

For this one i am waiting for a PR in imapct graph to get reviewd which gets the recurring dontaions from a data range.

@lovelgeorge99, could you take care of this and resolve this old issue? Thanks!

[divine-comedian]

@lovelgeorge99 what is the update on this issue?

[lovelgeorge99]

@divine-comedian this issuse was resolved here https://github.com/Giveth/giveth-dapps-v2/issues/3284

[divine-comedian]

Looks like MJs reported issue is done - moving this issue over to done.