Giveth / giveth-dapps-v2

This project is the aggregation of GIVeconomy and Giveth.io DApps in a single repo
https://staging.giveth.io
GNU General Public License v3.0
61 stars 34 forks source link

Multisig Integration - Users stuck in infinite sign-in loop on multisig #4248

Closed divine-comedian closed 3 weeks ago

divine-comedian commented 2 months ago

Many users trying to use the multisig integration are getting stuck at the sign-in

They are signing in with their Gnosis Safe, singing the on-chain message. However it is not being caught by Giveth and are prompted to sign another message, even though they should have already completed the log-in process by this point.

This is consuming a good amount of support and developer resources, we should fix this!

Here's just a few examples of relevant support tickets we're still dealing with! image image

cc: @jainkrati

jainkrati commented 2 months ago

Given Mateo is on leave for next two weeks, @RamRamez could you please take a look at this

divine-comedian commented 2 months ago

Following up here - from what I understand @mateodaza is being asked to take this issue up? Can we confirm this?

mateodaza commented 2 months ago

Following up here - from what I understand @mateodaza is being asked to take this issue up? Can we confirm this?

Gotta do an investigation side by side with backend, will sync with @CarlosQ96 to get it done

maryjaf commented 1 month ago

I've connected with my metamask wallet(not multisig) but this message is shown in passport banner

"Unfortunately Passport is not compatible with Multisigs, sign in with your regular wallet to verify your passport & make QF Donations."

image.png
mateodaza commented 1 month ago

It seems this changes made a problem on stg @mateodaza I've connected with my metamask wallet(not multisig) but this message is shown in passport banner

"Unfortunately Passport is not compatible with Multisigs, sign in with your regular wallet to verify your passport & make QF Donations."

image.png

Thankd for noticing. I'll take care of it :))

mateodaza commented 1 month ago

@maryjaf this PR fixes it

divine-comedian commented 1 month ago

Hey guys I just tried to check out the donate page of this project on STAGING

I'm connected to OP-Sepolia with my EOA and I see this pop-up image

project: https://staging.giveth.io/donate/Music-I'm-Listening-to-Now connected address: 0x826976d7C600d45FB8287CA1d7c76FC8eb732030

maryjaf commented 1 month ago

It seems this changes made a problem on stg @mateodaza I've connected with my metamask wallet(not multisig) but this message is shown in passport banner

"Unfortunately Passport is not compatible with Multisigs, sign in with your regular wallet to verify your passport & make QF Donations."

Some of my test related to QF was blocked by this his problem related to Gitcoin passport could someone check it as soon as possible? @mateodaza @MohammadPCh

image

divine-comedian commented 1 month ago

Still getting more reports of users getting stuck on this! Let's get some firepower on this bug and fix it up! image

maryjaf commented 1 month ago

image

https://github.com/Giveth/giveth-dapps-v2/assets/111529185/61460847-2f9e-4257-9e0f-ed918ae6c465

mateodaza commented 1 month ago

@maryjaf did you clean up your cache?

maryjaf commented 1 month ago

The issue related to passport score has been fixed, but I couldn't sign with my multisig account on stg, does it work for you? @mateodaza

requests.ts:30 https://auth.serve.giveth.io/v1/authentication? 500 (Internal Server Error)

image

maryjaf commented 1 month ago

The issue related to passport score has been fixed, but I couldn't sign with my multisig account on stg, does it work for you? @mateodaza

I got this error after signing by 2 signers requests.ts:30

https://auth.serve.giveth.io/v1/authentication? 500 (Internal Server Error)

image

Have you checked this? @mateodaza

maryjaf commented 1 month ago
maryjaf commented 1 month ago

Thanks @mateodaza the problem related to sign with multisig account has been fixed on staging and I could sign in successfully.