search

Giveth / giveth-dapps-v2

This project is the aggregation of GIVeconomy and Giveth.io DApps in a single repo
https://staging.giveth.io
GNU General Public License v3.0
54 stars 32 forks source link

fix: add toast warning for estimated matching less than minimumUsdValue #4278

Closed Meriem-BM closed 2 weeks ago

Meriem-BM commented 2 weeks ago

Related to #3829

@Ramim, for this issue the minimum USD value that @laurenluz said I had to pull from the BE was minimumValidUsdValue on qfRound table, right?

@laurenluz should I add a message when hovering over the warning icon? like below?

Screenshot 2024-06-14 at 14 17 41 (2)

Summary by CodeRabbit

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
giveth-dapps-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 19, 2024 8:38am
coderabbitai[bot] commented 2 weeks ago

Walkthrough

The changes across the codebase involve refining the donation matching messages in multiple languages, updating a HeaderWrapper component with new properties, and enhancing the EstimatedMatchingToast with additional UI logic and conditional rendering. These updates aim to clarify donation matching eligibility and improve user interaction.

Changes

Files Change Summary
lang/ca.json, lang/en.json, lang/es.json Updated and restructured donation matching toast messages
src/components/.../ArchivedQFRounds.view.tsx Added new properties $gap and $justifyContent to HeaderWrapper component
src/components/.../EstimatedMatchingToast.tsx Enhanced with new UI logic, conditional rendering, and restructuring

Sequence Diagram(s)

sequenceDiagram
    participant User
    User->>DonatePage: Initiates donation
    DonatePage->>EstimatedMatchingToast: Show matching toast
    EstimatedMatchingToast->>ValidationLogic: Check donation amount
    ValidationLogic->>EstimatedMatchingToast: Return validation result
    EstimatedMatchingToast->>DonatePage: Render UI based on validation
    DonatePage->>User: Display donation matching status

Poem

In the realm where code does sway,
Donation toasts now lead the way.
Languages three, they shine so bright,
With clearer texts, the goal in sight.
UI refined, logic so keen,
Together they make the perfect scene.
🌟✨

Recent review details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
Commits Files that changed from the base of the PR and between 6a97e3ce37230b8bf4336b71eaf6d216f1414bb0 and 96721a88110ee1f561cbb903117a008648b7a3b6.
Files selected for processing (5) * lang/ca.json (1 hunks) * lang/en.json (1 hunks) * lang/es.json (1 hunks) * src/components/views/archivedQFRounds/ArchivedQFRounds.view.tsx (3 hunks) * src/components/views/donate/EstimatedMatchingToast.tsx (4 hunks)
Files skipped from review as they are similar to previous changes (3) * lang/ca.json * lang/en.json * lang/es.json
Additional context used
Biome
src/components/views/archivedQFRounds/ArchivedQFRounds.view.tsx
[error] 44-44: This default parameter should follow the last required parameter or should be a required parameter. (lint/style/useDefaultParameterLast) The last required parameter is here: A default parameter that precedes a required parameter cannot be omitted at call site. Unsafe fix: Turn the parameter into a required parameter.
Additional comments not posted (4)
src/components/views/archivedQFRounds/ArchivedQFRounds.view.tsx (1)
`28-30`: Addition of `$gap` and `$justifyContent` to `HeaderWrapperProps` is clear and follows TypeScript conventions.
src/components/views/donate/EstimatedMatchingToast.tsx (3)
`6-6`: The addition of `IconAlertTriangleFilled` is appropriate for the warning functionality described in the PR. --- Line range hint `32-50`: Refactoring to use `React.FC` for `EstimatedMatchingToast` and the addition of new variables enhance the component's clarity and functionality. --- `53-102`: The new UI logic and conditional rendering based on `isAboveMinValidUsdValue` are well-implemented. Ensure thorough testing to confirm that the UI updates as expected.
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
RamRamez commented 2 weeks ago

@Ramim, for this issue the minimum USD value that @laurenluz said I had to pull from the BE was minimumValidUsdValue on qfRound table, right?

Yes, but minimumValidUsdValue in not used anywhere in the BE code, I'm not sure whether we apply this minimum amount or not. @CarlosQ96 @mohammadranjbarz can you confirm that minimumValidUsdValue is used in actual matching calculations or not?

Meriem-BM commented 2 weeks ago

@Ramim, for this issue the minimum USD value that @laurenluz said I had to pull from the BE was minimumValidUsdValue on qfRound table, right?

Yes, but minimumValidUsdValue in not used anywhere in the BE code, I'm not sure whether we apply this minimum amount or not. @CarlosQ96 @mohammadranjbarz can you confirm that minimumValidUsdValue is used in actual matching calculations or not?

@CarlosQ96, @mohammadranjbarz

cc: @RamRamez

mohammadranjbarz commented 2 weeks ago

minimumValidUsdValue

@RamRamez @Meriem-BM Yes we use it, you should search in the migration folder not src to find it, because we use it when creating the materialized view