search

Giveth / giveth-dapps-v2

This project is the aggregation of GIVeconomy and Giveth.io DApps in a single repo
https://staging.giveth.io
GNU General Public License v3.0
54 stars 32 forks source link

Adding hotfix for wallet connect modal #4291

Closed kkatusic closed 1 week ago

kkatusic commented 2 weeks ago

Fix #4109 , it is hotfix to hide additional wallet connect modal that is showing.

@MohammadPCh check this

Summary by CodeRabbit

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
giveth-dapps-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 18, 2024 8:20am
coderabbitai[bot] commented 2 weeks ago

Walkthrough

The primary change involves adding a CSS rule to hide the wcm-modal element by setting its display property to none. This modification aims to prevent the WalletConnect modal from repeatedly popping up.

Changes

File Change Summary
styles/globals.css Added display: none rule for wcm-modal element

Assessment against linked issues

Objective Addressed Explanation
Prevent WalletConnect widget from repeated popping (#4109) ✅

Poem

In the code's nocturnal night, A modal hid from sight. With a tweak so small, so right, The WalletConnect takes flight. No more pop-ups causing fright, CSS brings user delight. 🌟

Recent review details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
Commits Files that changed from the base of the PR and between 27bf037556718b02121ba6e7b2129a4ff6a9734f and 7adf98ed7ce1269a06884f49375dcc072d35acbb.
Files selected for processing (1) * styles/globals.css (1 hunks)
Additional context used
Biome
styles/globals.css
[error] 108-108: expected `,` but instead found `&` (parse) Remove & --- [error] 271-271: expected `,` but instead found `&` (parse) Remove &
Additional comments not posted (1)
styles/globals.css (1)
`294-295`: Correctly implemented CSS to hide the `wcm-modal`. This change should effectively prevent the WalletConnect modal from popping up repeatedly, aligning with the PR's objective.
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
maryjaf commented 2 weeks ago

I've checked on this branch and the problem of WalletConect widget popping out repeatedly doesn't happen again to me, but I couldn't sign in by wallet connect option could someone else check it with his device to be sure it works or not ? @kkatusic @MohammadPCh

My device: iphone 12 Desktop browser: chrome

kkatusic commented 2 weeks ago

I've checked on this branch and the problem of WalletConect widget popping out repeatedly doesn't happen again to me, but I couldn't sign in by wallet connect option could someone else check it with his device to be sure it works or not ? @kkatusic @MohammadPCh

My device: iphone 12 Desktop browser: chrome

What wallet you used? Can you test same on stagging?

maryjaf commented 2 weeks ago

I've checked on this branch and the problem of WalletConect widget popping out repeatedly doesn't happen again to me, but I couldn't sign in by wallet connect option could someone else check it with his device to be sure it works or not ? @kkatusic @MohammadPCh My device: iphone 12 Desktop browser: chrome

What wallet you used? Can you test same on stagging?

I had checked with metamask yesterday. maybe the problem was related to my connection because today I could sign with wallet connect->metamask

https://github.com/Giveth/giveth-dapps-v2/assets/111529185/eccca9e8-c60e-40ab-92b1-e5d279ad4476

kkatusic commented 2 weeks ago

I've checked on this branch and the problem of WalletConect widget popping out repeatedly doesn't happen again to me, but I couldn't sign in by wallet connect option could someone else check it with his device to be sure it works or not ? @kkatusic @MohammadPCh My device: iphone 12 Desktop browser: chrome

What wallet you used? Can you test same on stagging?

I had checked with metamask yesterday. maybe the problem was related to my connection because today I could sign with wallet connect->metamask Screen.Recording.2024-06-19.at.9.56.33.AM.mov

Can you please check in incognito mode and also in another browser? thx @maryjaf

maryjaf commented 2 weeks ago

I had checked with metamask yesterday. maybe the problem was related to my connection because today I could sign with wallet connect->metamask

I had also checked on incognito mode and firefox and it worked correctly

kkatusic commented 2 weeks ago

I had checked with metamask yesterday. maybe the problem was related to my connection because today I could sign with wallet connect->metamask

I had also checked on incognito mode and firefox and it worked correctly

Thx @maryjaf