search

Giveth / giveth-dapps-v2

This project is the aggregation of GIVeconomy and Giveth.io DApps in a single repo
https://staging.giveth.io
GNU General Public License v3.0
54 stars 32 forks source link

Added share on farcaster social network #4308

Closed kkatusic closed 1 week ago

kkatusic commented 1 week ago

Resolve #4167

Added share link option for Farcaster social network.

Summary by CodeRabbit

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
giveth-dapps-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 22, 2024 3:20pm
coderabbitai[bot] commented 1 week ago

Walkthrough

The recent updates introduce an option to share on Farcaster, a new social media platform. Corresponding labels were added for multiple languages, and functionality for sharing on Farcaster was integrated into the components responsible for social sharing, including the SocialBox, ShareModal, and ShareRewardedModal.

Changes

Files Change Summaries
lang/ca.json, lang/en.json, lang/es.json Added a new label label.share_on_farcaster for sharing on the Farcaster platform.
src/components/SocialBox.tsx Imported Warpcast icon and integrated a Link component for Farcaster sharing within the SocialItem component.
src/components/modals/ShareModal.tsx, src/components/modals/ShareRewardedModal.tsx Added an import for the Warpcast icon and included a Farcaster share button alongside existing social media sharing buttons.

Sequence Diagram(s)

The changes are straightforward and revolve around adding a new social sharing option, making it unnecessary to generate a sequence diagram for these modifications.

Assessment against linked issues

Objective Addressed Explanation
Allow sharing links directly to Farcaster (#4167) ✅

Poem

In the warren where codes entwine,
Now you can share, oh how divine!
From Twitter’s chirp to Farcaster’s gleam,
Your projects shine like a bunny's dream.
Hopping from one share to another,
Spread the word, dear code brother!

Recent review details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
Commits Files that changed from the base of the PR and between 92f9236cc367cc4ca3ebe6a0cdc4e6a546574cff and e85b3cd3966316d291d12c342406f81ef1969f21.
Files ignored due to path filters (2) * `public/images/icons/social-warpcast.svg` is excluded by `!**/*.svg` * `public/images/icons/social/warpcast.svg` is excluded by `!**/*.svg`
Files selected for processing (6) * lang/ca.json (1 hunks) * lang/en.json (1 hunks) * lang/es.json (1 hunks) * src/components/SocialBox.tsx (3 hunks) * src/components/modals/ShareModal.tsx (3 hunks) * src/components/modals/ShareRewardedModal.tsx (2 hunks)
Files skipped from review due to trivial changes (3) * lang/ca.json * lang/en.json * lang/es.json
Additional context used
Biome
src/components/modals/ShareRewardedModal.tsx
[error] 229-229: Unnecessary use of boolean literals in conditional expression. (lint/complexity/noUselessTernary) Simplify your code by directly assigning the result without using a ternary operator. If your goal is negation, you may use the logical NOT (!) or double NOT (!!) operator for clearer and concise code. Check for more details about NOT operator. Unsafe fix: Remove the conditional expression with --- [error] 299-299: Provide a href attribute for the a element. (lint/a11y/useValidAnchor) An anchor element should always have a href Check this thorough explanation to better understand the context.
Additional comments not posted (3)
src/components/SocialBox.tsx (1)
`11-11`: **Added imports for Farcaster sharing functionality.** The imports for `Link` from 'next/link' and the `Warpcast` icon are correctly placed and necessary for the new sharing feature on Farcaster. Ensure that the path to the `Warpcast` icon is correct and accessible. Also applies to: 20-20
src/components/modals/ShareModal.tsx (1)
`20-20`: **Added imports for Farcaster sharing functionality in ShareModal.** The import of `Warpcast` icon is correctly added and necessary for the new Farcaster sharing button. Ensure that the path to the `Warpcast` icon is correct and accessible. Also applies to: 25-25
src/components/modals/ShareRewardedModal.tsx (1)
`29-29`: **Added import for Farcaster sharing functionality in ShareRewardedModal.** The import of the `Warpcast` icon is correctly added for the new Farcaster sharing functionality. Ensure that the path to the `Warpcast` icon is correct and accessible.
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.