search

Giveth / giveth-dapps-v2

This project is the aggregation of GIVeconomy and Giveth.io DApps in a single repo
https://staging.giveth.io
GNU General Public License v3.0
54 stars 32 forks source link

Fix unsupported network modal #4310

Closed MohammadPCh closed 1 week ago

MohammadPCh commented 1 week ago

Summary by CodeRabbit

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
giveth-dapps-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 23, 2024 11:55am
coderabbitai[bot] commented 1 week ago

Walkthrough

The recent updates include version upgrades for several key dependencies in the package.json, the addition of a new configuration option for chain support in the Web3 modal setup in pages/_app.tsx, and the enhancement of conditional behavior in the WelcomeModal component through the use of isConnected from wagmi.

Changes

Files Change Summary
package.json Updated versions: @tanstack/react-query (5.36.0 to 5.45.1), @web3modal/wagmi (4.2.0 to 5.0.3), viem (2.10.5 to 2.16.1), wagmi (2.8.7 to 2.10.4)
pages/_app.tsx Added allowUnsupportedChain: false in the object for createWeb3Modal() configuration.
src/components/modals/WelcomeModal.tsx Imported useAccount from wagmi and used isConnected to adjust openConnectModal behavior.

Poem

In files of code, updates gleam bright,
Dependencies climbed, a worthy flight,
Web3 now knows what chains to shun,
Modal’s wiser, knows who's on.
Rabbit’s pleased, the code’s now grand,
Adventures await in Crypto-land! 🐇💻✨

Recent review details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
Commits Files that changed from the base of the PR and between 14df6b6b5579581d405819dde8e53f012cf3f450 and 804f1a5e8c2605870d05a75f31371c6711425a65.
Files ignored due to path filters (1) * `yarn.lock` is excluded by `!**/yarn.lock`, `!**/*.lock`
Files selected for processing (3) * package.json (2 hunks) * pages/_app.tsx (1 hunks) * src/components/modals/WelcomeModal.tsx (3 hunks)
Files skipped from review due to trivial changes (1) * package.json
Additional context used
Biome
src/components/modals/WelcomeModal.tsx
[error] 50-55: Change to an optional chain. (lint/complexity/useOptionalChain) Unsafe fix: Change to an optional chain.
pages/_app.tsx
[error] 227-227: Avoid passing content using the dangerouslySetInnerHTML prop. (lint/security/noDangerouslySetInnerHtml) Setting content using code can expose users to cross-site scripting (XSS) attacks
Gitleaks
pages/_app.tsx
58-58: Detected a Generic API Key, potentially exposing access to various services and sensitive operations. (generic-api-key)
GitHub Check: build
pages/_app.tsx
[warning] 128-128: 'url' is defined but never used. Allowed unused args must match /^_/u --- [warning] 174-174: React Hook useEffect has missing dependencies: 'asPath', 'pathname', 'query', and 'router'. Either include them or remove the dependency array
Additional comments not posted (3)
src/components/modals/WelcomeModal.tsx (2)
`8-8`: **Addition of `useAccount` from wagmi is appropriate for connection status logic.** This import is crucial for the new functionality added to handle connection status. It is correctly placed among other import statements. --- `26-26`: **Proper use of `isConnected` for dynamic modal behavior.** Extracting `isConnected` from `useAccount` and using it to conditionally adjust the modal's behavior is a logical enhancement, ensuring the modal reacts appropriately to the user's connection status. [APROVED]
pages/_app.tsx (1)
`102-102`: **Configuring `allowUnsupportedChain` to `false` is a secure and necessary update.** Adding `allowUnsupportedChain: false` to the `createWeb3Modal` configuration ensures that the application does not attempt to connect to unsupported blockchain networks, enhancing security and user experience.
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.