Closed Meriem-BM closed 6 days ago
vercel[bot]
commented
6 days ago The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| giveth-dapps-v2 | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jun 25, 2024 4:45pm |
coderabbitai[bot]
commented
6 days ago The recent updates focus on refining user interface text for clarity and functionality across multiple language files, enhancing Ethereum donation settings, modifying various project-related components for improved currency formatting, and upgrading the package.json version. Collectively, these changes enhance the ease of managing quadratic funding projects and accepting donations across multiple cryptocurrency chains.
| File Path | Change Summary |
|---|---|
lang/ca.json, lang/en.json, lang/es.json |
Updated donation settings labels for clarity and added information about accepting funds across more chains. |
package.json |
Updated the version from 2.28.0 to 2.28.1. |
src/components/project-card/ProjectCard.tsx |
Removed unused functions and updated currency formatting logic in EstimatedMatchingPrice. |
src/components/views/archivedQFRounds/ArchivedQFRoundsTable.tsx |
Added currency formatting (formatPrice) for displayed fund values. |
src/components/views/donate/EstimatedMatchingToast.tsx |
Modified formatWithCurrency function, removed getEstimatedMatchingRange function. |
src/components/views/project/projectActionCard/QFSection.tsx |
Replaced formatWithCurrency with formatDonation for simplified display logic. |
src/components/views/projects/qfBanner/ActiveQFProjectsBanner.tsx |
Added a new sponsor entry for @publicNouns. |
src/components/views/projects/qfBanner/common.ts |
Added new styling rules for sponsor elements. |
src/helpers/number.ts |
Enhanced formatDonation to use localized strings for numbers. |
src/helpers/qf.ts |
Commented out the getEstimatedMatchingRange function and related code. |
In code we trust, our path is set,
To make donations easier yet.
Ethereum addresses tailored fine,
Across chains the funds will intertwine.
With sponsors new and banners bright,
Quadratic funding takes its flight.
🐇✨💰
src/helpers/number.ts
[error] 54-54: Use the '**' operator instead of 'Math.pow'. (lint/style/useExponentiationOperator) Unsafe fix: Use the '**' operator instead of 'Math.pow'. --- [error] 73-73: isNaN is unsafe. It attempts a type coercion. Use Number.isNaN instead. (lint/suspicious/noGlobalIsNan) See the MDN documentation for more details. Unsafe fix: Use Number.isNaN instead.src/helpers/qf.ts
[error] 44-44: Use the '**' operator instead of 'Math.pow'. (lint/style/useExponentiationOperator) Unsafe fix: Use the '**' operator instead of 'Math.pow'. --- [error] 61-61: Use the '**' operator instead of 'Math.pow'. (lint/style/useExponentiationOperator) Unsafe fix: Use the '**' operator instead of 'Math.pow'. --- [error] 62-65: Use the '**' operator instead of 'Math.pow'. (lint/style/useExponentiationOperator) Unsafe fix: Use the '**' operator instead of 'Math.pow'.
src/components/views/archivedQFRounds/ArchivedQFRoundsTable.tsx (1)
`42-42`: **Improved display of allocated funds using formatting.** The update to use `formatPrice` for displaying allocated funds enhances readability and consistency in the UI.src/components/views/donate/EstimatedMatchingToast.tsx (1)
Line range hint `83-93`: **Enhanced formatting for estimated matching display.** The update to use `formatDonation` for formatting estimated matching amounts improves consistency and readability, aligning with changes in helper functions.src/components/views/project/projectActionCard/QFSection.tsx (1)
`85-93`: **Standardized formatting for donation amounts in quadratic funding sections.** The use of `formatDonation` for formatting donation amounts in various parts of the component ensures consistency and enhances readability. Also applies to: 121-135src/components/project-card/ProjectCard.tsx (2)
`25-25`: **Approved import change for `formatDonation`.** The change to import `formatDonation` from `@/helpers/number` instead of the previous `formatWithCurrency` and `getEstimatedMatchingRange` is consistent with the PR's objective to simplify currency formatting logic. --- Line range hint `238-253`: **Refactored currency formatting logic in the component.** The logic to format the estimated matching price has been refactored to use the new `formatDonation` function. This change simplifies the code and aligns with the PR's goal of improving clarity and maintainability. However, ensure that the change in the function signature and the logic doesn't affect other components that might rely on the same calculations.lang/en.json (2)
`70-70`: **Updated description for quadratic funding banner:** The change in the description for the quadratic funding banner clarifies the importance of donor numbers over the donation amount, which is a key principle of quadratic funding. This change enhances clarity and aligns with the goals of promoting broader participation. --- `1219-1219`: **Updated label for custom Ethereum address:** The updated label now includes additional information about the benefits of accepting donations on multiple chains, which could potentially increase the likelihood of receiving donations. This is a positive change as it provides clearer instructions and benefits directly to the users. [APROVED]lang/es.json (1)
`1219-1219`: **Updated localization for Spanish translation enhances clarity and inclusivity.** The updated text now includes additional information about accepting donations on multiple chains, which is likely to increase the appeal and accessibility of the platform for Spanish-speaking users.
Summary by CodeRabbit
New Features
Bug Fixes
Improvements
Version