Closed divine-comedian closed 1 day ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
giveth-dapps-v2 | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jun 28, 2024 5:47pm |
The update introduces a new label for feedback in multiple languages and integrates corresponding feedback links into the user interface. Specifically, it enhances user interaction by adding feedback links to the footer section and community items menu.
Files | Change Summary |
---|---|
lang/ca.json, lang/en.json, lang/es.json | Added a new label label.tell_us_how_we_are_doing for user feedback in Catalan, English, and Spanish. |
src/components/Footer/Footer.tsx | Included a new anchor element in the footer for a "Leave Feedback" link. |
src/components/menu/CommunityItems.tsx | Added a community item for feedback, modifying link behavior to open in a new tab. |
sequenceDiagram
participant User
participant Footer
participant CommunityItems
participant FeedbackPage
User->>Footer: Visits webpage
Footer->>User: Displays "Leave Feedback" link
User->>CommunityItems: Navigates to Community Menu
CommunityItems->>User: Displays feedback link in menu
User->>FeedbackPage: Clicks feedback link (opens in new tab)
FeedbackPage->>User: Shows feedback form
In the footer, a link so bright,
"Leave Feedback" shines in the night.
Catalan, Spanish, English, too,
Inviting words, so fresh and new.
Click away, your voice we seek,
In the space where feedback speaks.
🌟✨
src/components/menu/CommunityItems.tsx (2)
`33-37`: **New community item for feedback added.** The addition of a new community item for feedback is consistent with the PR objectives. The use of the `links.FEEDBACK` constant for the `href` attribute ensures that the link is maintained centrally, which is good for maintainability. --- `43-58`: **Conditional rendering logic for the new feedback link.** The conditional rendering logic correctly differentiates the feedback link to open in a new tab (`target='_blank'` with `rel='noreferrer noopener'`). This is a good security practice for links leading to external sites, ensuring that no referrer information is passed and that the new page cannot control the original page.src/components/Footer/Footer.tsx (1)
`125-135`: **New feedback link added in the footer.** The addition of the "Leave Feedback" link in the footer is well-implemented. The use of `target='_blank'` and `rel='noreferrer noopener'` for the anchor tag is a good practice for external links, ensuring security and proper behavior. The use of `formatMessage` with the `id` 'label.leave_feedback' aligns with the internationalization practices of the rest of the application. [APROVED]lang/en.json (1)
`980-980`: **New label addition confirmed and correctly implemented.** The JSON key `label.tell_us_how_we_are_doing` has been added successfully with the value "Tell us how we're doing", which aligns with the PR's objectives to solicit user feedback. The syntax is correct, and the key naming convention is consistent with other labels in the file.lang/ca.json (1)
`980-980`: **Addition of New Label for User Feedback** The new label `label.tell_us_how_we_are_doing` has been added correctly. This label is likely used to prompt users for feedback, which is a good enhancement for improving user engagement and collecting valuable user insights. The translation "Explica'ns com ho estem fent" seems appropriate for Catalan.
Summary by CodeRabbit
New Features
Localization