search

Giveth / giveth-dapps-v2

This project is the aggregation of GIVeconomy and Giveth.io DApps in a single repo
https://staging.giveth.io
GNU General Public License v3.0
61 stars 34 forks source link

Feat: add logic for QF eligibility with MBD #4357

Closed Meriem-BM closed 2 months ago

Meriem-BM commented 3 months ago

Related to #4247

Summary by CodeRabbit

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
giveth-dapps-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 15, 2024 8:13am
coderabbitai[bot] commented 3 months ago

Walkthrough

The updates enhance the Gitcoin Passport experience by refining text labels across multiple languages, introducing new donor eligibility checks, and improving user interaction with streamlined messages and new UI components. Notable changes include validating donation matching eligibility, updating loading/error messages, and adding new labels and components to manage passport-related states. A new React component, QFEligibilityRoute, aligns with these modifications, and GraphQL queries now include additional fields for detailed eligibility data.

Changes

File/Path Change Summary
lang/ca.json, lang/en.json, lang/es.json Updated text labels, messages, and added new labels for processing and eligibility information.
next.config.js Added a new redirection rule mapping /passport to /qf-eligibility.
package.json Updated @giveth/ui-design-system dependency version.
pages/qf-eligibility.tsx Introduced QFEligibilityRoute React component for QF eligibility page.
src/apollo/gql/gqlPassport.ts Added activeQFMBDScore field to GraphQL query SCORE_ACTIVE_QF_DONOR_ADDRESS.
src/apollo/gql/gqlQF.ts Added minimumUserAnalysisScore field to QF_ROUNDS_QUERY.
src/apollo/gql/gqlUser.ts Added activeQFMBDScore field to GET_USER_BY_ADDRESS query.
src/apollo/types/types.ts Added fields to IPassportInfo and IQFRound interfaces.
.../PassportBanner.tsx Added new states, updated content and conditional rendering for eligibility state.
.../PassportButton.tsx Allowed null value for state property in IButtonProps interface.
.../modals/PassportModal.tsx Introduced PassportModal component for managing and displaying passport eligibility information.
.../views/donate/QFToast.tsx Expanded functionality to include EQFElegibilityState alongside EPassportState.
.../views/donate/SuccessView.tsx Added qfEligibilityState to component state and eligibility checks logic.
.../views/passport/passport.view.tsx Integrated EQFElegibilityState into component's logic and updated references.
.../views/qfEligibility/QFEligibility.view.tsx Introduced QFEligibilityView component for eligibility status display and interactions.
.../views/userProfile/QFDonorEligibilityCard.tsx Introduced QFDonorEligibilityCard component for managing donor eligibility logic and display.
src/hooks/usePassport.ts Updated hook logic, added new states, functions, and eligibility scenarios handling.
src/services/passport.ts Added scoreUserAddress function and SCORE_ACTIVE_QF_DONOR_ADDRESS import.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant UI as User Interface
    participant API
    participant PassportService as Passport Service
    participant QFService as QF Eligibility Service

    User->>UI: Access eligibility page
    UI->>API: Fetch eligibility data
    API->>PassportService: Get Passport data
    PassportService->>API: Return Passport data
    API->>QFService: Check QF eligibility
    QFService->>API: Return QF eligibility status
    API->>UI: Send eligibility data
    UI->>User: Display eligibility status
    User->>UI: Update information
    UI->>API: Submit updated data
    API->>PassportService: Update Passport data
    PassportService->>API: Confirm update
    API->>UI: Confirm update
    UI->>User: Display updated status

Poem

In the realm of digital grace, Gitcoin Passport found its place, With messages fresh, and labels new, Your donations, matched and true. Eligibility clear as day, For you, the path, a smoother way. Celebrate, let's hop and cheer, For Gitcoin's updates far and near!

Recent review details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
Commits Files that changed from the base of the PR and between f05aa944047527585232ef9718371f4b3d38d25a and 8e0d8f1a92e4e42b104afcb8695808e856c5f0fd.
Files selected for processing (1) * src/services/passport.ts (2 hunks)
Files skipped from review as they are similar to previous changes (1) * src/services/passport.ts
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
Meriem-BM commented 2 months ago

Hey @RamRamez, @kkatusic if any of you guys can review this PR pls