Giveth / giveth-dapps-v2

This project is the aggregation of GIVeconomy and Giveth.io DApps in a single repo
https://staging.giveth.io
GNU General Public License v3.0
61 stars 34 forks source link

Fully Verified New Projects when viewed still shows the "Verify Tag" #4365

Closed LatifatAbdullahi closed 1 month ago

LatifatAbdullahi commented 3 months ago

When a new Project has been successfully Verified, when viewed, it still shows the "Verify Tag"

To Reproduce Steps to reproduce the behavior:

  1. Given a new Project has been verified
  2. And Users has signed in with wallet
  3. And Users navigates to "My Projects" on stage (https://staging.giveth.io/)
  4. And User check for the newly verified Project
  5. And User clicks on the Project Menu Action
  6. When User clicks on "View Project"
  7. Then there is "Verify Tag" on the Project

Expected behavior Successfully verified Projects should not show the "Verify Tag"

Screenshots image

Desktop OS: Windows 11 Browser : Chrome Version 126.0.6478.127 (Official Build) (64-bit)

Additional context When Users click on the "Verify Tag" it directs Users to a page showing they have been Verified and the Tag remains.

Meriem-BM commented 3 months ago

@divine-comedian for this issue it's frontend issue, we should just make sure the conditions reflect each other everywhere, here is where we should check

Screenshot 2024-07-02 at 11 06 38 1(2)

We should add a case to what to show when verified + project status is activated + is verified and the user on that page is the owner of the project Screenshot 2024-07-02 at 14 42 06 (2)

Here are the fields Screenshot 2024-07-02 at 11 18 24 (2)

Screenshot 2024-07-02 at 11 17 50 (2)

divine-comedian commented 3 months ago

@MohammadPCh - can you please pick this one up and find a solution based on @Meriem-BM 's findings

MohammadPCh commented 3 months ago

@kkatusic Can you take it?

kkatusic commented 3 months ago

@Meriem-BM thx for pointing that one combination of the submitting, verifying project is missing

maryjaf commented 2 months ago

I've checked the "MB" project and this problem happens because -The verification status of this project in "project verification form" is "verified" -but in "project" menu it's status is "not verify" and the tag in project page is changed from "verify project" into"boost" if the verify status of project in "project " menu in admin is "verify"

kkatusic commented 2 months ago

I've checked the "MB" project and this problem happens because -The verification status of this project in "project verification form" is "verified" -but in "project" menu it's status is "not verify" and the tag in project page is changed from "verify project" into"boost" if the verify status of project in "project " menu in admin is "verify"

Let's go throw steps, you create new project and verified it, after that project menu still showing "not verify"? Am I right?

maryjaf commented 2 months ago

I've checked the "MB" project and this problem happens because -The verification status of this project in "project verification form" is "verified" -but in "project" menu it's status is "not verify" and the tag in project page is changed from "verify project" into"boost" if the verify status of project in "project " menu in admin is "verify"

Let's go throw steps, you create new project and verified it, after that project menu still showing "not verify"? Am I right?

We should add a case to what to show when verified + project status is activated + is verified and the user on that page is the owner of the project Screenshot 2024-07-02 at 14 42 06 (2)

No, for my new verified project this problem doesn't happen I checked the @Meriem-BM project to check why this problem happened for "MB" project but for my projects it was ok

kkatusic commented 2 months ago

I've checked the "MB" project and this problem happens because -The verification status of this project in "project verification form" is "verified" -but in "project" menu it's status is "not verify" and the tag in project page is changed from "verify project" into"boost" if the verify status of project in "project " menu in admin is "verify"

Let's go throw steps, you create new project and verified it, after that project menu still showing "not verify"? Am I right?

We should add a case to what to show when verified + project status is activated + is verified and the user on that page is the owner of the project Screenshot 2024-07-02 at 14 42 06 (2)

No, for my new verified project this problem doesn't happen I checked the @Meriem-BM project to check why this problem happened for "MB" project but for my projects it was ok

How you can check her projects if you don't has her wallet? Can you advice me how can I check that? thx

maryjaf commented 2 months ago

How you can check her projects if you don't has her wallet? Can you advice me how can I check that? thx

I checked the status of this project from admin panel by name of project

maryjaf commented 2 months ago

Screenshots image

for @LatifatAbdullahi project as below pics the verification status in project menu isn't verify (verified:No - pic 2) and it is the reason why "verify project" button is shown in project page

but we should check why this problem and this discrepancy happened in "project " and "project verification form" in "verify" status Is this a bad data related to test data and some manual changing or there is a bug

image image

kkatusic commented 2 months ago

@maryjaf I think this happen when you verify project isnide verification form tab inside administration, than you unverify it from edit option of the project. @LatifatAbdullahi correct me if I wrong.

LatifatAbdullahi commented 2 months ago

@kkatusic

I remember making the Project update for verififcation only at the "Project" section, the only time I made an update in "Project verification" Tab was to Reject a project, all verifications have been in "Project" tab

maryjaf commented 2 months ago

for @LatifatAbdullahi project as below pics the verification status in project menu isn't verify (verified:No - pic 2) and it is the reason why "verify project" button is shown in project page

image

hmm, it's weird , in project menu in admin the status of verification for this project is : "verified:No" https://impact-graph.serve.giveth.io/admin/resources/Project/records/224038/show

maryjaf commented 2 months ago

Please let us now when the changes be merged. @kkatusic I couldn't recheck the verification flow and there were some weird behavior and when I check with @RamRamez he said this is related to last changes that hasn't been merged

RamRamez commented 2 months ago

@LatifatAbdullahi When you are trying to verify or reject verification status, please do not use the below checkbox. It's not our standard flow because they will directly change the DB without applying required logics. image

Please use the verify and reject button below for verification and rejection. image

I believe we can close this issue.

divine-comedian commented 2 months ago

@RamRamez is it possible to hide this checkbox to prevent confusion in the future?

RamRamez commented 2 months ago

Yes, I've hidden it for both project and verification form (in staging).

On Thu, Jul 11, 2024, 9:13 PM Mitch @.***> wrote:

@RamRamez https://github.com/RamRamez is it possible to hide this checkbox to prevent confusion in the future?

— Reply to this email directly, view it on GitHub https://github.com/Giveth/giveth-dapps-v2/issues/4365#issuecomment-2223522066, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARQKEQJ75DJ3PLPLZ5Z4HETZL273BAVCNFSM6AAAAABKHA4B66VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRTGUZDEMBWGY . You are receiving this because you were mentioned.Message ID: @.***>

maryjaf commented 2 months ago

Thanks @RamRamez I've checked, it works as expected

kkatusic commented 1 month ago

@divine-comedian can we close this? thx