search

Giveth / giveth-dapps-v2

This project is the aggregation of GIVeconomy and Giveth.io DApps in a single repo
https://staging.giveth.io
GNU General Public License v3.0
61 stars 34 forks source link

Add useDonationBox field to donation attributes and send it to backend #4366

Closed ae2079 closed 2 months ago

ae2079 commented 3 months ago

related to: https://github.com/Giveth/analytics-dashboard/issues/15

Summary by CodeRabbit

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
giveth-dapps-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 8, 2024 5:03pm
coderabbitai[bot] commented 3 months ago

Walkthrough

These changes enhance the donation flow by introducing new parameters useDonationBox and relevantDonationTxHash to various GraphQL mutations and functions. The updates aim to offer more flexibility and context when creating donations, especially focusing on whether a donation box is used and tracking relevant transaction hashes. The updates span multiple modules, including GraphQL mutations, React components, hooks, and service functions.

Changes

Files Change Summary
src/apollo/gql/gqlDonations.ts Added useDonationBox and relevantDonationTxHash parameters to CREATE_DONATION and CREATE_DRAFT_DONATION mutations.
src/components/views/donate/DonateModal.tsx Updated DonateModal component to include useDonationBox and relevantDonationTxHash based on conditions.
src/components/views/donate/helpers.tsx Added useDonationBox property to ICreateDonation interface.
src/hooks/useCreateEvmDonation.tsx Included useDonationBox parameter in various function calls and object assignments. Renamed useDonationBox to usingDonationBox in one call.
src/hooks/useCreateSolanaDonation.tsx Added useDonationBox and relevantDonationTxHash parameters in the useCreateSolanaDonation function.
src/services/donation.ts Updated createDonation function signature to include useDonationBox and relevantDonationTxHash parameters.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant DonateModal
    participant Hooks
    participant GQL
    participant Service

    User->>+DonateModal: Open
    DonateModal->>+Hooks: Use `useDonationBox` & `relevantDonationTxHash`
    Hooks->>+GQL: Call CREATE_DONATION
    GQL->>Service: Pass parameters
    Service-->>GQL: Handle Donation
    GQL-->>Hooks: Return Success
    Hooks-->>DonateModal: Update UI
    DonateModal-->>User: Display Info

Poem

In realms of code where functions flow,
New parameters help us grow.
A donation box, a hash to track,
Enhancing journeys, never looking back.
With these updates, we take flight,
Donations streamlined, shining bright. 🌟

Recent review details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
Commits Files that changed from the base of the PR and between aeeb173daf92a5dcf6d5d837ddcbe33da8ae0e8a and dbd9f658b0828a0bd1db789a4fa4a2d3eb24fae7.
Files selected for processing (2) * src/components/views/donate/OnTime/DonateModal.tsx (2 hunks) * src/components/views/donate/helpers.tsx (1 hunks)
Files skipped from review as they are similar to previous changes (1) * src/components/views/donate/helpers.tsx
Additional comments not posted (2)
src/components/views/donate/OnTime/DonateModal.tsx (2)
`211-211`: **LGTM!** The addition of the `useDonationBox` parameter to the `createFirstDonation` function call is correct and aligns with the PR objective. --- `227-228`: **LGTM!** The addition of the `useDonationBox` and `relevantDonationTxHash` parameters to the `createSecondDonation` function call is correct and aligns with the PR objective.
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.