Giveth / giveth-dapps-v2

This project is the aggregation of GIVeconomy and Giveth.io DApps in a single repo
https://staging.giveth.io
GNU General Public License v3.0
61 stars 34 forks source link

USD value not showing (GIV donations on Gnosis) #4370

Closed WhyldWanderer closed 1 month ago

WhyldWanderer commented 3 months ago

USD value is not showing correctly for donations made in GIV on Gnosis chain: image https://giveth.io/project/regens-unite?tab=donations

Seems like GIV on OP is fine though: image

WhyldWanderer commented 2 months ago

and update on this @jainkrati or @divine-comedian ?

I have had some reports from users regarding this. The QF donations are not showing in the matching because of this bug.

divine-comedian commented 2 months ago

and update on this @jainkrati or @divine-comedian ?

I have had some reports from users regarding this. The QF donations are not showing in the matching because of this bug.

I didn't even see this one! When you open issues in the future good that you assign me the issue so it pops up in my notifications

divine-comedian commented 2 months ago

@RamRamez - can you jump in to look at this bug since Cherik is out this week

RamRamez commented 2 months ago

This problem is already solved by @mohammadranjbarz in this commit. We were fetching price of GIV token from Subgraph, resulting errors but now we fetch from Coingecko. So the root cause of this problem has been resolved.

For GIV-earth round, we had a total of 53 donations without price, all of them in GIV. I added a script to fetch donations without price from DB and fill prices from Coingecko. This script can be called from AdminJS qfRound history tab (Coingecko rate limit is 5 requests per minute).

All 53 missing price donations are ok now.

image

RamRamez commented 2 months ago

@maryjaf @LatifatAbdullahi please test and verify. GIV donations price on staging should be filled correctly.

LatifatAbdullahi commented 2 months ago

On this!

LatifatAbdullahi commented 2 months ago

@divine-comedian @RamRamez

The GIV donation works as expected and the the USD price column is filled correctly.

lk