Closed kkatusic closed 2 months ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
giveth-dapps-v2 | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jul 23, 2024 11:23am |
The recent updates focus on enhancing the internationalization and verification logic of the project-related components within the application. The ProjectGIVbackToast
component now features a dynamically generated button label for better localization support. Additionally, the ProjectActions
component's verification logic has been refined to handle project verification status and form presence conditions more effectively.
File Path | Summary |
---|---|
.../project/ProjectGIVbackToast.tsx |
Updated button label to dynamically fetch text using formatMessage , enhancing localization. |
.../projectsTab/ProjectActions.tsx |
Modified condition logic for project verification status and form presence. |
No sequence diagrams are necessary for these changes as they involve minor updates to the verification logic and label rendering without altering the main control flow.
In the code where projects toast, A verification we now boast, Dynamic labels here to show, Languages of users flow. Actions check, conditions set, Verification's better yet. 🎉👨💻📈
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Noted
@kkatusic I believe we should only rely on project.verified to check for verification status. Also in backend we only check that field.
I removed the fields causing this error in AdminJS. I think the FE logic is ok.
Thx @RamRamez, I need this PR because I missed condition where it checks if verification form data either exist: https://github.com/Giveth/giveth-dapps-v2/pull/4372/commits/1dae5a9dc8b4c11246b6c5576d5a1dc653dda1af
Thx @RamRamez, I need this PR because I missed condition where it checks if verification form data either exist: 1dae5a9
@kkatusic The issue #4365 is tested and verified, so I think you can revert this commit and keep the rest.
Thx @RamRamez, I need this PR because I missed condition where it checks if verification form data either exist: 1dae5a9
@kkatusic The issue #4365 is tested and verified, so I think you can revert this commit and keep the rest.
Thx @RamRamez , but like I said before, we need this condition:
(!project.verified && project.projectVerificationForm === null)
from last commit
Thx @RamRamez, I need this PR because I missed condition where it checks if verification form data either exist: 1dae5a9
@kkatusic The issue #4365 is tested and verified, so I think you can revert this commit and keep the rest.
Thx @RamRamez , but like I said before, we need this condition:
(!project.verified && project.projectVerificationForm === null)
from last commit
@kkatusic Yes, I know. You can keep that one and just revert below commit. https://github.com/Giveth/giveth-dapps-v2/pull/4372/commits/003742ed80ce8f86cd5e1ae080597e2cae1dddaa
Thx @RamRamez , reverted ;)
@kkatusic could you please resolve the conflict? then we can merge it.
4365
@LatifatAbdullahi fixed project action dropdown menu when verify will show to user. Also added i18 label to verify project on single project page.
One combination was missing, when project verification form has been verified, but not verified project.
Summary by CodeRabbit
New Features
ProjectGIVbackToast
component now supports dynamic labeling for the verification button, enhancing internationalization and localization based on user language preferences.Bug Fixes
ProjectActions
component, ensuring more accurate handling of verification forms.