Giveth / giveth-dapps-v2

This project is the aggregation of GIVeconomy and Giveth.io DApps in a single repo
https://staging.giveth.io
GNU General Public License v3.0
61 stars 34 forks source link

Fix verify button & tag #4372

Closed kkatusic closed 2 months ago

kkatusic commented 3 months ago

@LatifatAbdullahi fixed project action dropdown menu when verify will show to user. Also added i18 label to verify project on single project page.

One combination was missing, when project verification form has been verified, but not verified project.

Summary by CodeRabbit

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
giveth-dapps-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2024 11:23am
coderabbitai[bot] commented 3 months ago

Walkthrough

The recent updates focus on enhancing the internationalization and verification logic of the project-related components within the application. The ProjectGIVbackToast component now features a dynamically generated button label for better localization support. Additionally, the ProjectActions component's verification logic has been refined to handle project verification status and form presence conditions more effectively.

Changes

File Path Summary
.../project/ProjectGIVbackToast.tsx Updated button label to dynamically fetch text using formatMessage, enhancing localization.
.../projectsTab/ProjectActions.tsx Modified condition logic for project verification status and form presence.

Sequence Diagram(s)

No sequence diagrams are necessary for these changes as they involve minor updates to the verification logic and label rendering without altering the main control flow.

Poem

In the code where projects toast, A verification we now boast, Dynamic labels here to show, Languages of users flow. Actions check, conditions set, Verification's better yet. 🎉👨‍💻📈


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
LatifatAbdullahi commented 3 months ago

Noted

kkatusic commented 2 months ago

@kkatusic I believe we should only rely on project.verified to check for verification status. Also in backend we only check that field.

I removed the fields causing this error in AdminJS. I think the FE logic is ok.

Thx @RamRamez, I need this PR because I missed condition where it checks if verification form data either exist: https://github.com/Giveth/giveth-dapps-v2/pull/4372/commits/1dae5a9dc8b4c11246b6c5576d5a1dc653dda1af

RamRamez commented 2 months ago

Thx @RamRamez, I need this PR because I missed condition where it checks if verification form data either exist: 1dae5a9

@kkatusic The issue #4365 is tested and verified, so I think you can revert this commit and keep the rest.

kkatusic commented 2 months ago

Thx @RamRamez, I need this PR because I missed condition where it checks if verification form data either exist: 1dae5a9

@kkatusic The issue #4365 is tested and verified, so I think you can revert this commit and keep the rest.

Thx @RamRamez , but like I said before, we need this condition:

(!project.verified && project.projectVerificationForm === null)

from last commit

RamRamez commented 2 months ago

Thx @RamRamez, I need this PR because I missed condition where it checks if verification form data either exist: 1dae5a9

@kkatusic The issue #4365 is tested and verified, so I think you can revert this commit and keep the rest.

Thx @RamRamez , but like I said before, we need this condition:

(!project.verified && project.projectVerificationForm === null)

from last commit

@kkatusic Yes, I know. You can keep that one and just revert below commit. https://github.com/Giveth/giveth-dapps-v2/pull/4372/commits/003742ed80ce8f86cd5e1ae080597e2cae1dddaa

kkatusic commented 2 months ago

Thx @RamRamez , reverted ;)

MohammadPCh commented 2 months ago

@kkatusic could you please resolve the conflict? then we can merge it.