Giveth / giveth-dapps-v2

This project is the aggregation of GIVeconomy and Giveth.io DApps in a single repo
https://staging.giveth.io
GNU General Public License v3.0
61 stars 34 forks source link

User donates lower than minimum usd value but in donation success page this message is shown "donation is eligible to be matched" #4539

Open maryjaf opened 1 month ago

maryjaf commented 1 month ago

Describe the bug

User donates lower than minimum usd value but in donation success page this message is shown "donation is eligible to be matched"

image

https://github.com/user-attachments/assets/4f1a4c5f-aa6a-4608-8c94-789e2b5a1cee

cc: @laurenluz @koday1

RamRamez commented 1 month ago

@HrithikSampson could you please take this issue? cc @jainkrati

maryjaf commented 1 month ago

Maybe some new design or copy is needed for this scenario .

laurenluz commented 1 month ago

Oh that's a good point @maryjaf. I think we can resolve this by changing the copy for both cases (qf eligible donor & not qf eligible donor) to be saying if the donor is eligible or not... and not mention the particular donation.

Scenario 1: The user is qf-eligible Title: Quadratic Funding Text: You are QF-eligible! As long as your donations are at least < minUSDvalue >, they are eligible to be matched in the round.

Scenario 2: The user is not qf-eligible (i.e. MBD not verified/checked, passport not verified/checked, passport score too low) Title: Quadratic Funding Text: Make sure your donations get matched! Verify your QF eligibility before < round end date >.

^^for this case, Scenario 2, < QF eligibility > should have a hyperlink to https://giveth.io/account

@HrithikSampson - is that good enough for you? or do you need design?

HrithikSampson commented 1 month ago

That's a great explanation @laurenluz , I dont need a design for it.

laurenluz commented 1 month ago

great!! :-D

maryjaf commented 1 month ago

Scenario 2: The user is not qf-eligible (i.e. MBD not verified/checked, passport not verified/checked, passport score too low) Title: Quadratic Funding Text: Make sure your donations get matched! Verify your QF eligibility before < round end date >.

^^for this case, Scenario 2, < QF eligibility > should have a hyperlink to https://giveth.io/account

You mean this current flow should be changed also ? @laurenluz image image

HrithikSampson commented 1 month ago

Sorry, I misunderstood it.

I have initially implemented it wrong. I had considered Scenario 1 as the donation is more than the minimumValidUsdValue for the project and the Donor is QF eligible

For the case of Scenario 2 I had considered it when the Donor is QF eligible but has made a donation lesser than the minimumValidUsdValue for the project. The flow with QF Donor eligibility Modal I had kept the same as shown in the screenshot as shown above from @maryjaf.

Since I assumed the wrong scenarios, right now I was also wondering whether the current Flow will be changed.

I was also thinking that a scenario could occur when the user is QF eligible but has donated lesser than the minimumValidUsdValue for the project.

@laurenluz I have these doubts regarding the two scenarios?