Giveth / giveth-dapps-v2

This project is the aggregation of GIVeconomy and Giveth.io DApps in a single repo
https://staging.giveth.io
GNU General Public License v3.0
61 stars 34 forks source link

Stellar| Mobile view - donation page #4572

Open maryjaf opened 4 weeks ago

maryjaf commented 4 weeks ago

There are some problems on mobile view

image

https://github.com/user-attachments/assets/85427670-dd2b-49b6-ad69-0ce5e2123bf3

image

cc: @MoeNick

maryjaf commented 4 weeks ago

image

Meriem-BM commented 3 weeks ago

@maryjaf you can check this.

maryjaf commented 3 weeks ago

Thanks @Meriem-BM These 3 items have been fixed But because of this blocker that I've reported on discord channel, I couldn't complete donation scenario on mobile. after fixing this problem and completing donation on mobile I'll move it to done

cc: @MoeNick

MoeNick commented 3 weeks ago

The blocker is removed, right?

maryjaf commented 3 weeks ago

https://github.com/user-attachments/assets/522f568c-79d3-47f2-826f-fdb8f80ad72f

Success donation:


https://stellar.expert/explorer/public/tx/29f3a35d68d09c3ba244db9b3373b765d8d638129c68396e0a0a9452cf74ca7d image

But there is no record with this amount 0.011 in donation table


image

@Meriem-BM

Meriem-BM commented 3 weeks ago

Hey @maryjaf it's the 1st one, ti has the same transaction link, maybe there is an amount format that keeps 2 digits, I'll check.

maryjaf commented 3 weeks ago

Hey @maryjaf it's the 1st one, ti has the same transaction link, maybe there is an amount format that keeps 2 digits, I'll check.

so I think it's the same problem with this https://github.com/Giveth/giveth-dapps-v2/issues/4566#issuecomment-2298396473 , since my user isn't signed in on mobile i expect the record is set anonymous

maryjaf commented 3 weeks ago

Is there any UI change on mobile view that should be applied in point of your view? @MoeNick if not, I'll move this issue to done and we can track the last problem on related issue (# 4566)

MoeNick commented 3 weeks ago

Please check the responsiveness with Stellar Figma.

maryjaf commented 3 weeks ago

Is there any UI change on mobile view that should be applied in point of your view? @MoeNick if not, I'll move this issue to done and we can track the last problem on related issue (# 4566)

The reported UI problems have been fixed, I meant If other changes needed let us know since I haven't seen separate design for mobile, If there a figma for mobile view Please share it here

MoeNick commented 3 weeks ago

https://www.figma.com/file/5qh6OaJRJSCNj2h22MMSwa?node-id=1:103&locale=en&type=design#917906640

If you scroll down you can find transaction responsiveness design as well.

maryjaf commented 3 weeks ago

image

Figma: image