search

Giveth / giveth-dapps-v2

This project is the aggregation of GIVeconomy and Giveth.io DApps in a single repo
https://staging.giveth.io
GNU General Public License v3.0
64 stars 34 forks source link

Remove email verification from verification form #4579

Open divine-comedian opened 3 months ago

divine-comedian commented 3 months ago

As part of #4476 anyone who adds an email to their profile will need to verify their ownership. This means that asking users to verify email ownership when applying for project verification will be redundant, since we already have a verified email associated with the project owner.

We should ensure that the email verification component is removed from the verification form. The email that is associated with the project owner's profile should be used when submitting the application data and also for sending any subsequent project verification related emails.

image

divine-comedian commented 5 days ago

@kkatusic this one will also need to be done before we can release email verification feature.

Since we are verifying project owner's email it is no longer necessary to make them verify their email again on the givbacks eligiblity form.

kkatusic commented 5 days ago

@divine-comedian this wont be easy, let's think with BE guy @CarlosQ96 , if I remove this should I remove all fields related to email verification process inside project_verification_form table and all related logics on BE? What you @CarlosQ96 suggest? thx

divine-comedian commented 5 days ago

Is it possible instead to remove the field from the UI and send some data to the back-end that says the email is already verified. We could even send the email that is already listed on the project owner's user profile.

kkatusic commented 3 days ago

Is it possible instead to remove the field from the UI and send some data to the back-end that says the email is already verified. We could even send the email that is already listed on the project owner's user profile.

Some kind of camouflage, BE is handling all data submission and if you click "Verify" than it runs verification procedure, timing, dating, generating token... it should be also removed from BE side, or on first submission make it validated

kkatusic commented 3 days ago

Let me check now

divine-comedian commented 3 days ago

@kkatusic following up from convo today - see if we can insert the user.profile on creating the form. Or we can insert the user email on the step/function where it is expecting the email in the form.

The givbacks eligibility forms (verification form) are kept as separate objects from user data, I think it is only loosely associated with the project data itself.

We should try to keep the table entry there since remove any table data from our DB could create lots of unexpected consequences.

Please ask questions to @CarlosQ96 for any advice on how to handle requirements the BE needs to make hiding the front-end elements possible.

kkatusic commented 3 days ago

@divine-comedian I removed and tested, after approve QF staff will test it better in all cases ;)