search

Giveth / giveth-dapps-v2

This project is the aggregation of GIVeconomy and Giveth.io DApps in a single repo
https://staging.giveth.io
GNU General Public License v3.0
61 stars 34 forks source link

Stellar | GIVback eligiblity #4582

Open maryjaf opened 3 weeks ago

maryjaf commented 3 weeks ago

"Is givback eligible" is set for this token https://impact-graph.serve.giveth.io/admin/resources/Token/records/306/show but I haven't seen the donation with stellar in response of this API

curl -X 'GET' \ 'https://givback.develop.giveth.io/eligible-donations?chain=all-other-chains&startDate=2024%2F08%2F18-00%3A00%3A00&endDate=2024%2F08%2F19-23%3A59%3A59&download=no' \ -H 'accept: application/json'

cc: @MoeNick @Meriem-B

MoeNick commented 3 weeks ago

Also, the icon for Stellar should be demonstrated with a tiny GIVback hand icon.

maryjaf commented 3 weeks ago

This issue hasn't been assigned yet

mohammadranjbarz commented 3 weeks ago

@maryjaf @MoeNick Now we have some restrictions that send givbacks for EVM donations, should we change it? Because if we change it to support non-EVM donations we need to find a solution to send givbacks for them as the script and the format that we use for sending givbacks is only available on Gnosis and OP chain. Correct me if I'm wrong @laurenluz @WhyldWanderer

GriffGreen commented 3 weeks ago

We would send GIVbacks on OP, not on Stellar, like we do for donations on Arbitrum, the main thing is that it will only work if they are logged in with a Ethereum profile (not a solana profile)

mohammadranjbarz commented 3 weeks ago

We would send GIVbacks on OP, not on Stellar, like we do for donations on Arbitrum, the main thing is that it will only work if they are logged in with a Ethereum profile (not a solana profile)

Thanks @GriffGreen , will work on that

mohammadranjbarz commented 2 weeks ago

FYI @maryjaf @MoeNick it's deployed on Staging

maryjaf commented 2 weeks ago

but I haven't seen the donation with stellar in response of this API

curl -X 'GET' 'https://givback.develop.giveth.io/eligible-donations?chain=all-other-chains&startDate=2024%2F08%2F18-00%3A00%3A00&endDate=2024%2F08%2F19-23%3A59%3A59&download=no' -H 'accept: application/json'

So I should see the stellar donation in response of this api now? @mohammadranjbarz

divine-comedian commented 2 weeks ago

Hey guys! I was testing the flow today and wanted to add a comment related to this issue:

For me it wasn't obvious that if I'm not signed in with my EVM profile I won't get GIVbacks! It would be nice to remind me if I'm not signed in that I should do it, otherwise I'll miss out on GIVbacks!

Image

divine-comedian commented 2 weeks ago

Also! If I'm not signed in and make a successful donation I shouldn't see the GIVbacks component on the donation success page, since I won't actually get GIVbacks

Image

maryjaf commented 1 week ago

but I haven't seen the donation with stellar in response of this API curl -X 'GET' 'https://givback.develop.giveth.io/eligible-donations?chain=all-other-chains&startDate=2024%2F08%2F18-00%3A00%3A00&endDate=2024%2F08%2F19-23%3A59%3A59&download=no' -H 'accept: application/json'

So I should see the stellar donation in response of this api now? @mohammadranjbarz

{ "amount": 0.1, "currency": "XLM", "createdAt": "2024-09-01-07:49:00", "valueUsd": 0.0092289, "bottomRankInRound": null, "givbacksRound": null, "projectRank": null, "givbackFactor": 0.75, "valueUsdAfterGivbackFactor": 0, "giverAddress": "0xa047b554b435674eb28fd4553201cb1a800be53b", "txHash": "0383be71d2d726233e09477973d44ac8338ea7ce9df10f4faca405d202d3306c", "network": "stellar", "source": "giveth.io", "giverName": "testaccoun2 mozila", "giverEmail": null, "projectLink": "https://giveth.io/project/test-stellar", "isReferrerGivbackEligible": false, "referrerWallet": null },

I donated to test stellar project, and above record is shown in response of givback api. Is the value of these below fields correct? @mohammadranjbarz

"bottomRankInRound": null, "givbacksRound": null,
"valueUsdAfterGivbackFactor": 0,

MoeNick commented 1 week ago

Thanks, @divine-comedian for raising those issues, those will be addressed on the issues above so as not to distract the GIVback API QA.

maryjaf commented 1 week ago

I donated to test stellar project, and above record is shown in response of givback api. Is the value of these below fields correct? @mohammadranjbarz

"bottomRankInRound": null, "givbacksRound": null, "valueUsdAfterGivbackFactor": 0,

@mohammadranjbarz @Meriem-B

mohammadranjbarz commented 1 week ago

0383be71d2d726233e09477973d44ac8338ea7ce9df10f4faca405d202d3306c

I checked the stellar donations on staging, the rank info is null for all of them as you see in this screenshot

Screenshot 1403-06-13 at 11 37 17 in the morning

@Meriem-B Can you investigate it? I spent about 1 hour but couldn't find the reason, if you could not find it as well, please write some test cases for this scenario, reproduce it in test cases and then fix it ( Ask me if you need help)

mohammadranjbarz commented 1 week ago

@maryjaf can you test it again? It should work for new donations that you will create from now on

maryjaf commented 1 week ago

Now this record is shown in response of givback eligibility It seems the problem has been fixed @mohammadranjbarz

"givbacksRound": 49443 is this filed filled correctly?

{ "amount": 0.1, "currency": "XLM", "createdAt": "2024-09-03-09:53:00", "valueUsd": 0.0093546, "bottomRankInRound": 33, "givbacksRound": 49443, "projectRank": 33, "givbackFactor": 0.5, "valueUsdAfterGivbackFactor": 0.0046773, "giverAddress": "0x7f37e3008207c27360b20abcfb5fdcc8e37596b8", "txHash": "d02a1bf00da3ffcc344d4700ff2dfadfe3d28bd981a8765565a8fcf27babd305", "network": "stellar", "source": "giveth.io", "giverName": "maryamaa mehr", "giverEmail": null, "projectLink": "https://giveth.io/project/test-stellar", "isReferrerGivbackEligible": false, "referrerWallet": null },

mohammadranjbarz commented 1 week ago

w

Now this record is shown in response of givback eligibility It seems the problem has been fixed @mohammadranjbarz

"givbacksRound": 49443 is this filed filled correctly?

{ "amount": 0.1, "currency": "XLM", "createdAt": "2024-09-03-09:53:00", "valueUsd": 0.0093546, "bottomRankInRound": 33, "givbacksRound": 49443, "projectRank": 33, "givbackFactor": 0.5, "valueUsdAfterGivbackFactor": 0.0046773, "giverAddress": "0x7f37e3008207c27360b20abcfb5fdcc8e37596b8", "txHash": "d02a1bf00da3ffcc344d4700ff2dfadfe3d28bd981a8765565a8fcf27babd305", "network": "stellar", "source": "giveth.io", "giverName": "maryamaa mehr", "giverEmail": null, "projectLink": "https://giveth.io/project/test-stellar", "isReferrerGivbackEligible": false, "referrerWallet": null },

Thanks @maryjaf yes it's ok