Giveth / giveth-dapps-v2

This project is the aggregation of GIVeconomy and Giveth.io DApps in a single repo
https://staging.giveth.io
GNU General Public License v3.0
61 stars 34 forks source link

project page and donation flow updates for verified projects (not givbacks eligible) #4597

Open divine-comedian opened 1 month ago

divine-comedian commented 1 month ago

Project details page

We should ensure there is a corresponding component for when a project has reached the verified status but is no yet givbackEligible.

Image

This project is eligible to be boosted with GIVpower but will not yield GIVbacks to it's donors. @Tosinolawale @mosaeedi we will need a DESIGN for this new component version.

here's some text:

Boost this project with GIVpower!

Stake & lock your GIV tokens to get GIVpower. Boost this project make it more visible on the projects page!

We'll also need to fix the copy on the current "verified" version of this component to be accurate for givbacks eligible projects:

Get rewarded with up to {givbacksFactor}% of your donation value!

Ethereum donations to this project are rewarded with GIV. Boost this project to increase its rewards percentage and make it more visible on the projects page!

Successful donation page

We'll need to make sure that when donating to a verified but not givbacks eligible project we show the donate success page as it currently is when donating to a non-verified project

Image

verified & givbacks eligible badge

when a project is givbacks eligible we should ensure both the verified and givbacks eligible badge is shown on the project card and project details page, next to the verified badge. I think we had an badge design for this once upon a time @Tosinolawale if you can help find this or design a quick one.

To note, this likely will change when we move into the full specification and we will be showing different badges when we get the time to move into the full specification of this project.


Summary Task list:

for testing

Tosinolawale commented 3 weeks ago

GIVBacks Eligible verified projects Project Single - About2

GIVbacks not eligible verified projects Project Single - About

https://www.figma.com/design/fHpNMd8Q9iBrAr6kBj9oo5/DeVouch-Giveth-Integration?node-id=8214-4238&t=8P26W4jR0mgkG3SQ-1 @divine-comedian

divine-comedian commented 3 weeks ago

@mateodaza this should be ready for you now

LatifatAbdullahi commented 5 days ago

@mateodaza @divine-comedian

Test Update

-Copy change on component on project details page for projects that are vouched but NOT GIVbacks eligible is correct - Pending

@mateodaza Seems the "Stake and lock" should be a hyperlink that redirects to the Giveconomy section, but its not here

hh

When a project is Verified and Givback eligible - Pass

Project card - Pass gk

Project details page - Pass ij

Project cards - Pass cg

lk

image

mm

However, from the Designs, we have a section showing the amounts raised by the Projects on the Success page, but it is missing on staging. @mateodaza

Staging

dfff

Design

dee

mateodaza commented 5 days ago

@LatifatAbdullahi @divine-comedian for this last point

However, from the Designs, we have a section showing the amounts raised by the Projects on the Success page, but it is missing on staging.

It was on purpose set to false and not display this part, was this maybe an old requirement? I can easily change it but just wanna be double sure

<DonatePageProjectDescription
     projectData={project}
     showRaised={false}
/>
LatifatAbdullahi commented 5 days ago

@mateodaza Seems the "Stake and lock" should be a hyperlink that redirects to the Giveconomy section, but its not here

![hh](https://private-user-images.githubusercontent.com/112261242/368333387-d7adaf63-c672-468b-a1f0-37781fe68ca4.png?

@mateodaza Also this "Stake and lock" section as Hyperlink

mateodaza commented 5 days ago

yes :) that'll be fixed @LatifatAbdullahi

mateodaza commented 4 days ago

Here's the PR

divine-comedian commented 4 days ago

looks like it's been merged - can we retest @LatifatAbdullahi ?

LatifatAbdullahi commented 4 days ago

Sure

LatifatAbdullahi commented 4 days ago

@mateodaza This section has not been updated to Hyperlink

srr

All good with the missing Raised amounts and all other sections

rs

ret

LatifatAbdullahi commented 2 hours ago

@mateodaza The hyperlink section has not been updated please take a look