search

Giveth / giveth-dapps-v2

This project is the aggregation of GIVeconomy and Giveth.io DApps in a single repo
https://staging.giveth.io
GNU General Public License v3.0
61 stars 34 forks source link

Stellar | Allow redundant addresses for Stallar if their MEMO is diffrent #4645

Open MoeNick opened 1 month ago

MoeNick commented 1 month ago

If some project owners going to use a similar exchange like LBank, all their addresses will be the same but with different MEMOs, so we should consider this case. It should be unique for each project, if 2 projects are using the same addresses at least they have to have different MEMOs. We should check this on the backend side on save and edit.

image

CC: @maryjaf

Meriem-BM commented 4 weeks ago

Hey @MoeNick will we should change the error message too?

MoeNick commented 4 weeks ago

Good catch @Meriem-BM if the user puts the same address and MEMO we should say: This address is already used for another project with the same MEMO. Please enter a different address or a different MEMO.

Thanks

maryjaf commented 3 weeks ago

There is a UI problem in this modal when user enters a repetitive address and memo @Meriem-BM

https://github.com/user-attachments/assets/1fb2c0d6-d3ba-40c7-86cc-e8d33de2d667

Meriem-BM commented 3 weeks ago

There is a UI problem in this modal when user enters a repetitive address and memo @Meriem-BM

Screen.Recording.2024-09-02.at.1.04.06.PM.mov

@maryjaf I can't see this UI misplacement, I tested on Brave, Chrome, Arc

Meriem-BM commented 3 weeks ago

Oh, got it, it happens when I opened console down.