search

Giveth / giveth-dapps-v2

This project is the aggregation of GIVeconomy and Giveth.io DApps in a single repo
https://staging.giveth.io
GNU General Public License v3.0
61 stars 34 forks source link

Stellar | check to show GIVback components, if users is not eligible. #4659

Open MoeNick opened 2 weeks ago

MoeNick commented 2 weeks ago 
          Also! If I'm not signed in and make a successful donation I shouldn't see the GIVbacks component on the donation success page, since I won't actually get GIVbacks

Image

Originally posted by @divine-comedian in https://github.com/Giveth/giveth-dapps-v2/issues/4582#issuecomment-2319142373

MoeNick commented 2 weeks ago

Based on the above report @Meriem-B

We should check the users eligibility with these conditions:

  1. Project is verified
  2. Token is GIVback eligible
  3. User is signed in

Those conditions would be effective on

  1. GIVback icon on token logo
  2. The toast message on reminding to sign in
  3. the GIVback components on success page.

FYI: @maryjaf

maryjaf commented 2 weeks ago
  • GIVback icon on token logo

So when my user isn't signed in, the GIVback eligible icon shouldn't be shown? @MoeNick Now in this case the givback icon is shown @Meriem-BM

Image

maryjaf commented 2 weeks ago

The showing of GIVback components on success page works as expected

Not signed user :

Image

Sign user:

Image

MoeNick commented 2 weeks ago
  • GIVback icon on token logo

So when my user isn't signed in, the GIVback eligible icon shouldn't be shown? @MoeNick Now in this case the givback icon is shown @Meriem-BM

Image

I think it's fine @maryjaf , user can see the icon and givback eligibility toast message. so lets put it in done