Change GIVbacks % bubble text for min donation amount & lottery

Giveth / giveth-dapps-v2

This project is the aggregation of GIVeconomy and Giveth.io DApps in a single repo

https://staging.giveth.io

GNU General Public License v3.0

64 stars 33 forks source link

Change GIVbacks % bubble text for min donation amount & lottery #4683

Closed laurenluz closed 2 months ago

laurenluz commented 2 months ago

[x] GIVbacks eligible, public user view Get rewarded with up to x% of your donation value! A donation of $5 or more makes you eligible to recieve GIVbacks. Boost this project to increase its rewards percentage and make it more visible on the projects page!
[x] GIVbacks eligible, project owner view Donations of $5 or more qualify for GIVbacks with up to x% of the donation value! Boost your project to increase its GIVbacks % and increase its visibility among other projects!
[ ] Non- GIVbacks eligible, public view Can we just remove this bubble entirely? @mosaeedi @WhyldWanderer ?
[ ] Non- GIVbacks eligible, project owner view @WhyldWanderer @mosaeedi can you help me find what it says in this case?

mosaeedi commented 2 months ago

@laurenluz I made some changes to the copy to reduce the description to two lines, Please let me know if it's okay. I've removed the no GIVbacks

I also noticed we have another one, should I still keep it?

If we have to keep it, I suggest to change the copy,

laurenluz commented 2 months ago

figma link here: https://www.figma.com/design/jrgULA0ZGWcfjRn0aXyPwj/DS---UI-Elements?node-id=11-19471&t=cnxwdnabGvQqpxrC-4

laurenluz commented 2 months ago

For the GIVbacks V2 changes, I think we only need to consider 2 alterations @RamRamez

[x] GIVbacks eligible project, public view
[x] GIVbacks eligible project, project owner view

link to figma

The above changes are required for the Sept 16/Sept 17 release.

... Later...

For the following release when we separate GIVbacks & verification, we should also adjustments for cases cases for:

Verified (vouched) but not GIVbacks eligible project, public view
Verified (vouched) but not GIVbacks eligible project, project owner view (who has not applied for verification)
Verified (vouched) but not GIVbacks eligible project, project owner view (who has applied for verification)
Non-verified project, public view
Non-verified project, project owner view

cc @divine-comedian

RamRamez commented 2 months ago

For the GIVbacks V2 changes, I think we only need to consider 2 alterations @RamRamez

[x] GIVbacks eligible project, public view

[x] GIVbacks eligible project, project owner view

link to figma

The above changes are required for the Sept 16/Sept 17 release.

... Later...

For the following release when we separate GIVbacks & verification, we should also adjustments for cases cases for:

Verified (vouched) but not GIVbacks eligible project, public view

Verified (vouched) but not GIVbacks eligible project, project owner view (who has not applied for verification)

Verified (vouched) but not GIVbacks eligible project, project owner view (who has applied for verification)

Non-verified project, public view

Non-verified project, project owner view

cc @divine-comedian

These two are done! @maryjaf please test and verify https://giveth-dapps-v2-git-release17sep-givethio.vercel.app/

maryjaf commented 2 months ago

Thanks @RamRamez GIVback eligible copy for public and owner view have been changed based on the design

Non- GIVbacks eligible views haven't been changed and I think based on the above comment it isn't necessary for this release