On page refresh sometimes the token list does not appear

Giveth / giveth-dapps-v2

This project is the aggregation of GIVeconomy and Giveth.io DApps in a single repo

https://staging.giveth.io

GNU General Public License v3.0

64 stars 33 forks source link

On page refresh sometimes the token list does not appear #4686

Closed divine-comedian closed 1 month ago

divine-comedian commented 2 months ago

Latifat reported this issue that sometimes the token list doesn't load and she needs to refresh in order to make it appear

I have noticed is the slight glitch when refreshing both on stage and production. what do you think?

https://github.com/user-attachments/assets/e74f259c-5b5a-4188-a973-775ebbdb47e3

Originally posted by @LatifatAbdullahi in https://github.com/Giveth/giveth-dapps-v2/issues/4557#issuecomment-2329183097

Howver I think simply it is taking a while to load. In order to prevent confusion we should show the spinning loading wheel instead of showing "no token balances" while the app is loading up the tokens.

Additionally

When loading the token list sometimes the balance appears as -- it should continue loading the rest of the token balances and if the balance is 0 then it should show 0 instead of --

LatifatAbdullahi commented 2 months ago

@divine-comedian

It loads after a couple of seconds

https://github.com/user-attachments/assets/5498b24b-b06d-4d13-8716-a146914e61ee

divine-comedian commented 2 months ago

@lovelgeorge99 assigning this to you when you have bandwidth to take it.

divine-comedian commented 2 months ago

@divine-comedian

It loads after a couple of seconds

DeSci.Round.Operation.Group._.Giveth.-.Google.Chrome.2024-09-04.16-15-44.mp4

Thanks! We still need to check out the 2nd point of the token balances showins as --

lovelgeorge99 commented 2 months ago

@divine-comedian It loads after a couple of seconds DeSci.Round.Operation.Group._.Giveth.-.Google.Chrome.2024-09-04.16-15-44.mp4

Thanks! We still need to check out the 2nd point of the token balances showins as --

Ok got it ... will work on this

LatifatAbdullahi commented 1 month ago

@divine-comedian Test Update

This now works as expected with the loader added.

https://github.com/user-attachments/assets/8b78ff4c-9c95-4eab-9cb2-580fbcb41832

divine-comedian commented 1 month ago

@LatifatAbdullahi could you also test out if any token balances appear as --

If you already did and can confirm this is resolved we can keep in Done

LatifatAbdullahi commented 1 month ago

@divine-comedian

No token balance appears as --