fix: network modal showing while the page is loading

HrithikSampson commented 2 months ago

I have closed both the networkModal and the sanctioned wallet address when I close the sanctions Modal if both networkModal and the sanctionsModal appear and user clicks inside the sanctions Modal to visit all projects page. the networkModal wont interfere

relates to https://github.com/Giveth/giveth-dapps-v2/issues/4449#issuecomment-2329143840

and relates to #4449

relates also to #4612 and test can be seen in #4712 for OFAC Sanctions Modal, as for all wallet addresses it returns sanctioned in #4712

I have tried to show only one modal in donation page. Sometimes modals were coinciding and interupting the flow.

Summary by CodeRabbit

New Features
- Enhanced donation modal management for a more streamlined user experience.
- Introduced dynamic control over donation modals based on project ownership.
- Improved handling of modal priorities to simplify user interactions during the donation process.
- Added new functionalities for managing modal states and priorities effectively.
- Integrated wallet sanction validation to ensure compliance during donations.
- New modal for displaying sanction information based on user wallet status.
Bug Fixes
- Refined the logic for displaying modals to prevent premature closure during navigation events.

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
giveth-dapps-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 26, 2024 0:42am

coderabbitai[bot] commented 2 months ago

Walkthrough

The changes enhance the donation modal management across multiple components. Key updates include the introduction of a new enum for modal priorities, improved state management for modal visibility, and refined logic for handling wallet sanctions. The DonateIndex.tsx component has been updated to integrate these changes, ensuring that modals are displayed accurately based on user interactions and conditions.

Changes

Files	Change Summary
`src/components/views/donate/DonateIndex.tsx`	Enhanced donation processes with improved modal display logic, sanction validation for specific wallets, and refined rendering conditions for modals.
`src/context/donate.context.tsx`	Introduced `DonateModalPriorityValues` enum and updated context with new functions and state variables to manage modal visibility and priority effectively.

Possibly related PRs

#4285: Enhancements in DonateIndex.tsx align with updates in modal management.
#4626: Introduces a new modal in DonationByProjectOwner.tsx that prevents users from donating to their own projects, relating to modal handling in the main PR.
#4700: Changes in DonateIndex.tsx include new state management for donation types, connecting to modal display logic updates in the main PR.
#4734: Modifications in DonateIndex.tsx add state variables related to donation types, linking to modal rendering changes in the main PR.

Suggested reviewers

mohammadranjbarz
Meriem-BM

Poem

🐰 In the meadow where donations flow,
Modals dance and smoothly glow.
With each click, the path is clear,
Hopping along, we spread good cheer!
Changes made, a joyful tune,
In the garden, we all swoon! 🌼

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

:heart: Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

:placard: Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

HrithikSampson commented 2 months ago

relates to #4449 and #4612

divine-comedian commented 1 month ago

@mohammadranjbarz to review!

Giveth / giveth-dapps-v2