Giveth / giveth-dapps-v2

This project is the aggregation of GIVeconomy and Giveth.io DApps in a single repo
https://staging.giveth.io
GNU General Public License v3.0
62 stars 33 forks source link

Document the "things we forgot about" during zkEVM integration, for use in future GIVeconomy integrations #4723

Closed laurenluz closed 1 month ago

laurenluz commented 2 months ago

This issue will be part of the zkeVM integration product and we can then use it/fork it for future giveconomy integrations. Want to make sure we don't repeat the same mistake, so we should document

Things like:

@mohammadranjbarz cc @aminlatifi @geleeroyale

mohammadranjbarz commented 1 month ago

@laurenluz I think this document is completed now https://gist.github.com/mohammadranjbarz/a44f3cede21d5aa7e82ef127b90c8235

laurenluz commented 1 month ago

yay mohammad I think that's great

@aminlatifi do you have to have a quick look and if it's all good, we can close this issue?

aminlatifi commented 1 month ago

I see the doc is a gist under Mohammad's account. @mohammadranjbarz can you put it somewhere under Giveth ownership? Also, I will be able to put comments for later possible amendments

mohammadranjbarz commented 1 month ago

I see the doc is a gist under Mohammad's account. @mohammadranjbarz can you put it somewhere under Giveth ownership? Also, I will be able to put comments for later possible amendments

Yes of course, but I can't create gist under Giveth organization, can you do it and give me the link to add my content there?

aminlatifi commented 1 month ago

Not necessary gist, we can find another place. Like a README file in giveconomy foundry repo

mohammadranjbarz commented 1 month ago

Not necessary gist, we can find another place. Like a README file in giveconomy foundry repo

I added it in giv-token-contract readme https://github.com/Giveth/giv-token-contracts/pull/106

laurenluz commented 1 month ago

ok nice! @aminlatifi is that good? should we close this?

aminlatifi commented 1 month ago

ok nice! @aminlatifi is that good? should we close this?

Let me review please

aminlatifi commented 1 month ago

Reviewed

laurenluz commented 1 month ago

lovely - thanks guys @mohammadranjbarz @aminlatifi - let's keep this doc in mind for next time!!