Giveth / giveth-dapps-v2

This project is the aggregation of GIVeconomy and Giveth.io DApps in a single repo
https://staging.giveth.io
GNU General Public License v3.0
64 stars 33 forks source link

1810 usdglo token #4795

Closed HrithikSampson closed 1 month ago

HrithikSampson commented 1 month ago

relates to https://github.com/Giveth/impact-graph/issues/1810

Summary by CodeRabbit

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
giveth-dapps-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2024 7:00pm
coderabbitai[bot] commented 1 month ago

Walkthrough

The changes in this pull request encompass significant modifications to GraphQL queries and fragments in src/apollo/gql/gqlProjects.ts, particularly the removal and re-addition of the isGivbackEligible field. Additionally, the configuration settings in src/config/production.tsx have been updated to include a new super token, "Glo Dollar," and the BASE_ROUTE has been altered. Furthermore, the src/configuration.ts file reflects a logical inversion in determining the production environment. These updates reflect a restructuring of project data representation and configuration for blockchain networks.

Changes

File Change Summary
src/apollo/gql/gqlProjects.ts - Removed and re-added isGivbackEligible from multiple fragments and queries.
- Expanded queries to include new fields such as categories, organization, and addresses.
- Adjusted qfRounds to include eligibleNetworks and minimumValidUsdValue.
- Added fields like description, socialMedia, and totalProjectUpdates to FETCH_PROJECT_BY_SLUG_SINGLE_PROJECT.
- Updated ADD_RECIPIENT_ADDRESS_TO_PROJECT mutation to include reviewStatus and slugHistory.
src/config/production.tsx - Updated BASE_ROUTE to use 'https://mainnet.serve.giveth.io'.
- Added new super token "Glo Dollar" with properties including id, name, symbol, and coingeckoId.
src/configuration.ts - Inverted logic for isProduction constant to check if NEXT_PUBLIC_ENV is not equal to 'production'.
next-env.d.ts - Updated comment to reflect the new URL for Next.js TypeScript documentation.
src/components/views/donate/OneTime/SelectTokenModal/SelectTokenModal.tsx - Updated import to use fetchEVMTokenBalances for fetching token balances.
src/components/views/donate/Recurring/SelectTokenModal/SelectTokenModal.tsx - Enhanced balance fetching logic to use fetchEVMTokenBalances for concurrent fetching of multiple token balances.
src/services/token.ts - Renamed fetchTokenBalances to fetchEVMTokenBalances and updated its signature for better type handling.

Possibly related PRs

Suggested reviewers

Poem

In the code where tokens play,
A new friend joins the fray today!
Glo Dollar hops with joy and cheer,
A fresh route shines, the path is clear.
With every change, our project grows,
A rabbit's dance, as progress flows! 🐰✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
divine-comedian commented 1 month ago

this looks like it is removing some important data from the project data such as the isGivbacksEligible field @mateodaza could you review this PR when you have some time?

divine-comedian commented 1 month ago

@HrithikSampson can we close this branch?

HrithikSampson commented 1 month ago

Hi @divine-comedian , I have updated it to not force production on staging should I merge this to staging or directly to production since it cannot be tested on staging

divine-comedian commented 1 month ago

@HrithikSampson since this token doesn't exist on staging we should make sure this code does not go to production - I think this PR ca be closed.