search

Giveth / giveth-dapps-v2

This project is the aggregation of GIVeconomy and Giveth.io DApps in a single repo
https://staging.giveth.io
GNU General Public License v3.0
64 stars 33 forks source link

Problem in switch network modal on staging #4801

Open maryjaf opened 1 month ago

maryjaf commented 1 month ago

Describe the bug

when the switch network modal is shown in donation page, by tapping on supported network , the switch nework is done but the modal won't be closed and it is shown constantly .

https://github.com/user-attachments/assets/ab9180a8-0aac-4c5f-8bb2-c56fffebf99f

cc: @divine-comedian

maryjaf commented 1 month ago

It seems this problem is related to this change https://github.com/Giveth/giveth-dapps-v2/issues/4612#issuecomment-2340901810 @MohammadPCh

maryjaf commented 1 month ago

It seems last changes made some problem in previous passed scenario, by changing the user the project owner modal is still shown @HrithikSampson

https://github.com/user-attachments/assets/037a7325-dfe6-457f-84ff-3426307a6b60

maryjaf commented 1 month ago

Describe the bug

when the switch network modal is shown in donation page, by tapping on supported network , the switch nework is done but the modal won't be closed and it is shown constantly .

Screen.Recording.2024-10-01.at.11.00.18.PM.mov cc: @divine-comedian

This problem has been fixed, but is the below screen record is ok? by tapping on op sepolia , switch network is disappeared for a sec and it is shown again but after switching network it isn't shown again

https://github.com/user-attachments/assets/57113f57-0bf9-40b5-9c72-ed87104b9cfa

@HrithikSampson @MohammadPCh

MohammadPCh commented 1 month ago

@maryjaf Thanks for testing :) We need to refactor this part, but it's not a blocker for release. So let's release it and then fix this UI problem. @HrithikSampson can you take this?

HrithikSampson commented 1 month ago

Sure @MohammadPCh

maryjaf commented 1 month ago

It seems last changes made some problem in previous passed scenario, by changing the user the project owner modal is still shown @HrithikSampson

Screen.Recording.2024-10-02.at.2.11.28.PM.mov

can you fix it before release? @HrithikSampson

HrithikSampson commented 1 month ago

Not Sure

It seems last changes made some problem in previous passed scenario, by changing the user the project owner modal is still shown @HrithikSampson Screen.Recording.2024-10-02.at.2.11.28.PM.mov

can you fix it before release? @HrithikSampson

maryjaf commented 1 month ago

So should we deploy this change with these 2 problems in this release or revert it ? @divine-comedian cc: @HrithikSampson @MohammadPCh

divine-comedian commented 1 month ago

@maryjaf it looks like this is ready to be tested again

maryjaf commented 1 month ago

It seems last changes made some problem in previous passed scenario, by changing the user the project owner modal is still shown @HrithikSampson

Screen.Recording.2024-10-02.at.2.11.28.PM.mov

this problem hasn't been fixed and after changing account the page should be refreshed @divine-comedian

maryjaf commented 1 month ago

Describe the bug when the switch network modal is shown in donation page, by tapping on supported network , the switch nework is done but the modal won't be closed and it is shown constantly . Screen.Recording.2024-10-01.at.11.00.18.PM.mov cc: @divine-comedian

This problem has been fixed, but is the below screen record is ok? by tapping on op sepolia , switch network is disappeared for a sec and it is shown again but after switching network it isn't shown again

Screen.Recording.2024-10-02.at.2.13.37.PM.mov @HrithikSampson @MohammadPCh

this problem has been fixed @kkatusic @divine-comedian