Giveth / giveth-dapps-v2

This project is the aggregation of GIVeconomy and Giveth.io DApps in a single repo
https://staging.giveth.io
GNU General Public License v3.0
64 stars 33 forks source link

Ensure correct emails are sent for project status changes related to decentralized verification #4805

Closed divine-comedian closed 1 month ago

divine-comedian commented 1 month ago

we should ensure correct emails are sent on the corresponding admin actions related to decentralized verification

project tab -> verify project

image

this action should not trigger any email ... for now. currently it triggers the GIVbacks acceptance email which is incorrect

project -> reject

image this action should not trigger any email ... for now. currently it triggers the GIVbacks rejection email which is incorrect.

project verification form tab -> approve projects

currently it triggers the GIVbacks acceptance email which is CORRECT

project verification form tab -> reject projects

currently it triggers the GIVbacks rejection email which is CORRECT.

revoke badge

image

this should send the badge revoked email currently NO email is triggered @RamRamez we send the same call but verified-status = "revoked"

AC

CarlosQ96 commented 1 month ago

Currently the project verify/revoke and verification-form approved/reject, trigger the same action. I can disable it for the first two.

RamRamez commented 1 month ago

@maryjaf @LatifatAbdullahi please test and verify

divine-comedian commented 1 month ago

All AC are passed Nice work!